Make WordPress Core

Opened 4 weeks ago

Closed 12 days ago

Last modified 12 days ago

#66079 closed task (blessed) (fixed)

Update the reverbnation.com oEmbed endpoint

Reported by: johnbillion Owned by: whyisjake
Priority: normal Milestone: 7.1.3
Component: Embeds Version:
Severity: normal Keywords: has-patch has-test-info has-screenshots
Cc: Focuses:

Description

The oEmbed endpoint for reverbnation.com returns a 404. The endpoint has moved to its "legacy" subdomain but the existing oEmbed endpoint doesn't redirect to it.

Old endpoint:

New endpoint:

I suppose the URL matcher should be updated to support legacy.reverbnation.com too because URLs such as https://www.reverbnation.com/theweakerthans now redirect there.

Attachments (3)

ticket-66079-before-old-endpoint.png​ (7.3 KB ) - added by arkaprabhachowdhury 3 weeks ago.
Old www endpoint response: 404
ticket-66079-after-legacy-endpoint.png​ (27.4 KB ) - added by arkaprabhachowdhury 3 weeks ago.
Legacy endpoint response: valid oEmbed JSON
ticket-66079-after-playground.png​ (483.1 KB ) - added by arkaprabhachowdhury 3 weeks ago.
WordPress Playground editor with live ReverbNation embed

Download all attachments as: .zip

Change History (13)

#1 @adamsilverstein
4 weeks ago

@johnbillion - thanks for the ticket!

Is there a reason this needs to be in 7.1.1? This endpoint wasn't introduced in 7.1, so I'm curious why you think we need to back port the fix?

#2 @adamsilverstein
4 weeks ago

  • Milestone 7.1.1 → 7.1.2

7.1.1 RC is in a couple of hours - punting this to 7.1.2 for continued work.

This ticket was mentioned in ​PR #13485 on ​WordPress/wordpress-develop by ​@yogeshbhutkar.


3 weeks ago
#3

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/66079

## What, Why, and How?

ReverbNation moved their site and oEmbed API to legacy.reverbnation.com. The old www endpoint 404s and never redirects, so artist and song URLs stop embedding with the old URL. www pages still redirect to legacy, however, our matcher only allowed www, so a pasted legacy link never used the sanctioned provider. Legacy URLs didn't match the provider array, so they fell through to discovery via the page’s oEmbed <link> tags.

This PR updates the provider row: point the endpoint at legacy.reverbnation.com/oembed, and match both www and legacy so either hostname uses that API as a provider instead of discovery.

## Screencast

​https://github.com/user-attachments/assets/c34aa9bf-8f87-4233-bd1d-1e5eb789754c

## Use of AI Tools

AI assistance: Yes
Tool(s): Codex
Model(s): GPT-6 Astra
Used for: Validating the regex and running discovery on oEmbed endpoints for artists, songs, albums, and collections.

@arkaprabhachowdhury
3 weeks ago

Old www endpoint response: 404

@arkaprabhachowdhury
3 weeks ago

Legacy endpoint response: valid oEmbed JSON

@arkaprabhachowdhury
3 weeks ago

WordPress Playground editor with live ReverbNation embed

#4 @arkaprabhachowdhury
3 weeks ago

  • Keywords has-test-info has-screenshots added

Test Report

This report validates that PR #13485 addresses Trac #66079.

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/13485 at b15fd432083c94297c806e4b63cdefbf0d2bfb49

The patch updates the ReverbNation provider matcher to accept both www.reverbnation.com and legacy.reverbnation.com, and uses ​https://legacy.reverbnation.com/oembed as the provider endpoint.

Environment

  • WordPress 7.2-alpha-20260911.061210, PR #13485 Playground build
  • PHP 7.4
  • WordPress Playground / PHP.wasm
  • Playwright-controlled Chromium on Windows

Results

  • [pass] The old www endpoint returned a 404 response.
  • [pass] The legacy endpoint returned valid oEmbed JSON for The Weakerthans.
  • [pass] The legacy.reverbnation.com URL rendered a live ReverbNation embed.
  • [pass] The www.reverbnation.com URL also rendered a live ReverbNation embed.

Screenshots

  • ticket-66079-before-old-endpoint.png
  • ticket-66079-after-legacy-endpoint.png
  • ticket-66079-after-playground.png

This ticket was mentioned in ​Slack in #core by adrianduffell. ​View the logs.


3 weeks ago

#6 @johnbillion
13 days ago

  • Milestone 7.1.2 → 7.1.3

#7 @whyisjake
12 days ago

  • Owner set to whyisjake
  • Status new → accepted

#8 @whyisjake
12 days ago

  • Resolution → fixed
  • Status accepted → closed

In 63907:

Embeds: Update the ReverbNation oEmbed endpoint.

ReverbNation has moved its site and oEmbed API to the legacy.reverbnation.com subdomain. The previous www.reverbnation.com/oembed endpoint returns a 404 Not Found response and does not redirect, so embeds of artist and song URLs stopped working. This points the provider at the new endpoint and extends the URL pattern to match legacy.reverbnation.com, which www.reverbnation.com URLs now redirect to.

Props johnbillion, yogeshbhutkar, arkaprabhachowdhury, adamsilverstein.
Fixes #66079.

#9 @whyisjake
12 days ago

In 63908:

Embeds: Update the ReverbNation oEmbed endpoint.

ReverbNation has moved its site and oEmbed API to the legacy.reverbnation.com subdomain. The previous www.reverbnation.com/oembed endpoint returns a 404 Not Found response and does not redirect, so embeds of artist and song URLs stopped working. This points the provider at the new endpoint and extends the URL pattern to match legacy.reverbnation.com, which www.reverbnation.com URLs now redirect to.

Reviewed by whyisjake.
Merges r63907 to the 7.1 branch.

Props johnbillion, yogeshbhutkar, arkaprabhachowdhury, adamsilverstein.
Fixes #66079.

​@whyisjake commented on ​PR #13485:


12 days ago
#10

Thanks for contributing @yogeshbhutkar!

Note: See TracTickets for help on using tickets.