WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#6609 closed defect (bug) (fixed)

Magpie improperly parses Google ATOM feeds

Reported by: karlkatzke Owned by:
Milestone: 2.8 Priority: high
Severity: critical Version: 2.5
Component: General Keywords: magpie simplepie
Focuses: Cc:

Change History (16)

comment:1 karlkatzke6 years ago

I specifically want to point out:

http://trac.wordpress.org/ticket/2683#comment:5

We all know what assume means, right?

Therefore, Magpie needs to be updated and/or the bugs need to be fixed so that Gdata atom feeds are properly consumed and parsed.

comment:2 Otto426 years ago

#2683 is rather old, what you should be looking at are past tickets like #4547.

We need to dump Magpie entirely. It's dead, Jim.

And no, I still don't understand why matt is so dead set against including a library that doesn't suck instead of including one that does.

comment:3 ryan6 years ago

I think it's just a matter of providing back compat.

comment:4 zamoose6 years ago

2.5 broke a LOT of back-compat in a lot of admin places, etc. I'd say we should toss this in as a "2.6 breaks it" feature.

comment:5 karlkatzke6 years ago

It's OK to provide back-compat and keep Magpie in the chain, but for god's sakes provide an easier way to use something different.

One of these days, we'll all get to stop supporting PHP4 and actually get to use abstraction and all that other good OOP stuff in PHP5. That'd make maintaining backwards compatibility and maintaining multiple libraries/plugins for things like parsing PHP a snap.

comment:6 follow-up: karlkatzke6 years ago

Err, for parsing RSS.

comment:7 in reply to: ↑ 6 zamoose6 years ago

Replying to karlkatzke:

Err, for parsing RSS.

'Sokay, my neural parser was in error correcting mode -- I think I actually read 'RSS' though you typed PHP. Dunno about anyone else.

*grin*

comment:8 jeremyclarke6 years ago

The newer versions of Magpie do a great job at lots of feed types and don't break the existing uses of the old version of the library in wp. the feedwordpress plugin (an aggregator) asks you to upload two files into wp-includes that overwrite the existing magpie with an updated version and it works fine. see this article about it:
http://projects.radgeek.com/2008/04/18/compatability-bugs-and-possible-quick-fixes-for-issues-with-feedwordpress-after-upgrading-to-wordpress-25/

I think using those files would be great for wp as a whole and for encouraging people to use those libraries like they use jquery rather than including a whole other library just for the plugin. it would also be nice to not have to re upload them each time there's an upgrade.

If that's not an option then +1 for abstracting it out a bit so that plugins can at least overwrite the library in favor of their own without overwriting the files (FWP could then just use the newer version on their own time but keep the wrappers and stuff).

comment:9 Otto426 years ago

Even the newer Magpie is still pretty poor at Google feeds. I did the same thing with one of my older plugins (dropped in a newer Magpie). But the simple fact is that Magpie is a dead project.

The latest version of it is three years old: http://sourceforge.net/project/showfiles.php?group_id=55691

We should use software that is actively supported and maintained.

As far as backward compatibility goes, that's easy. We leave the rss-functions.php file there as is, and use some other file instead. Add the deprecated tags and function calls to it. Change all the internal bits of WordPress to use the new library. Remove Magpie after a few versions. No problem.

comment:10 filosofo6 years ago

What library do you suggest?

comment:11 Otto426 years ago

The most popular and active one seems to be SimplePie.

comment:12 ryan6 years ago

  • Milestone changed from 2.5.2 to 2.9

Milestone 2.5.2 deleted

comment:13 rmccue6 years ago

  • Cc rmccue added
  • Keywords magpie simplepie added

As an official developer for SimplePie, I'm up for integrating SimplePie if you're willing to accept a patch for it.

comment:14 link926 years ago

See #4547. This was previously marked as WONTFIX.

comment:15 hakre5 years ago

Everybody who feel the way, can freely integrate SimplePie. See #4547, all rss routines can be overloaded within the wordpress API. Just create a SimplePie Wordpress Plugin, a official one would be nice. If you need help with that, just drop me a line.

comment:16 ryan5 years ago

  • Milestone changed from 2.9 to 2.8
  • Resolution set to fixed
  • Status changed from new to closed

We now use SimplePie. see #9198

Note: See TracTickets for help on using tickets.