Make WordPress Core

Opened 4 weeks ago

Closed 4 weeks ago

#66090 closed defect (bug) (fixed)

Remove Screencast from the list of supported oEmbed providers

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Priority: normal Milestone: 7.2
Component: Embeds Version: 6.8.2
Severity: normal Keywords: good-first-bug has-patch
Cc: Focuses: docs

Description

This is just a documentation change, as support for screencast.com has already been removed as of WordPress 6.8.2, but the list of supported providers in the oembed_providers filter DocBlock was not updated, so screencast.com is now present in both the supported and the not-supported sections of that list, see lines 178 and 221​.

Follow-up to r60345 / #61941.

Change History (4)

This ticket was mentioned in ​PR #13479 on ​WordPress/wordpress-develop by ​mahesh-pawar.


4 weeks ago
#1

  • Keywords has-patch added; needs-patch removed

Remove Screencast from the list of supported oEmbed providers.

Trac ticket: https://core.trac.wordpress.org/ticket/66090

Trac ticket:

## Use of AI Tools

#2 follow-up: @maheshpawar2012
4 weeks ago

Hi Sergey!

I've opened a PR for this: ​https://github.com/WordPress/wordpress-develop/pull/13479 Screencast has been removed from the list of oEmbed providers in WP_oEmbed::__construct(), along with its entry in the supported providers docblock. The oEmbed test group passes locally (npm run test:php -- --group oembed). Props welcome on review. Happy to make changes if anything else should go along with the removal.

#3 in reply to: ↑ 2 @SergeyBiryukov
4 weeks ago

Replying to maheshpawar2012:

I've opened a PR for this: ​https://github.com/WordPress/wordpress-develop/pull/13479

The PR looks good (with the feedback addressed), thank you!

#4 @SergeyBiryukov
4 weeks ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 63605:

Docs: Remove Screencast from the list of supported oEmbed providers.

This is just a documentation change, as support for screencast.com has already been removed as of WordPress 6.8.2.

This commit updates the list of supported providers in the oembed_providers filter DocBlock to reflect that change.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13479.

Follow-up to r60345.

Props maheshpawar2012, westonruter, SergeyBiryukov.
Fixes #66090.

Note: See TracTickets for help on using tickets.