WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6629 closed defect (bug) (fixed)

HTML uploads fail

Reported by: tellyworth Owned by:
Milestone: 2.5.1 Priority: normal
Severity: normal Version: 2.5
Component: General Keywords: has-patch
Focuses: Cc:

Description

HTML uploads fail with the error "Specified file failed upload test." from the Add Image tab:

  1. Disable Flash
  1. Click 'Add Image'
  1. Browse, select an image file, Ok
  1. Click 'Upload'
  1. The file uploads but returns with "Specified file failed upload test."

Reason: media_handle_upload() gets called twice, from both media_upload_image() and media_upload_form_handler(). The first one succeeds, the second causes the error because the file has been moved.

Removing the block of code as per the enclosed patch seems to fix it. That code appears to be unused - at least I can't find anything that breaks as a result of removing it.

Attachments (1)

legacy-uploader-fix-r7567.patch (803 bytes) - added by tellyworth 7 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 @ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [7706]) Legacy uploader fix from tellyworth. fixes #6629 for 2.5

comment:2 @ryan7 years ago

(In [7707]) Legacy uploader fix from tellyworth. fixes #6629 for trunk

Note: See TracTickets for help on using tickets.