Internally, pass arrays instead of query strings to functions that use wp_parse_args()

[ryan]

Within core WP, we should pass arrays instead of query strings to functions that pass their args through wp_parse_args(). Arrays are faster, more secure, and avoid quoting bugs. See [7625] for an example conversion from a query string to an array.

[DD32]

attachment 6647.diff added.

Just some that i came accross while creating a patch for #6772, The changes in wp-includes/media.php have been duplicated in a patch on that ticket. I'll refresh this patch if need be when that tickets fixed.

[ryan]

(In [7894]) Use array calling style. Props DD32. see #6647

[ryan]

(In [7911]) Use array calling style. see #6647

[Denis-de-Bernardy]

fixed?

[Denis-de-Bernardy]

there are still a few in the default theme. do we want them fixed?

[Denis-de-Bernardy]

get_bookmarks(), get_categories(), get_terms(), wp_get_object_terms() each have a few more

[Denis-de-Bernardy]

untested patch attached

[Denis-de-Bernardy]

wp() might also need to be looked into:

wp("post_type=post&$post_status_q&posts_per_page=$posts_per_page&order=$order&orderby=$orderby");

[ryan]

Leaving open to catch any further ones.

[ryan]

[12515]

[filosofo]

Here are a few more that turned up in a grep.

[hakre]

I jumped in as well and found some more. Merged that together with filosofo's findings.

[Denis-de-Bernardy]

patch still applies clean. could we get this checked in?

[westi]

(In [12657]) Switch to passing arrays instead of query strings to functions. Fixes #6647 props filosofo and hakre.