Evaling the $query in Class WP throws a notice

[simonwheatley]

I've just turned on the WP_DEBUG (#5033), for more picky error handling and am making an effort to clean up my WP install to run with no errors of any kind (not even Notices).

The evaling of $query in the Class WP throws a Notice as all indexes in $matches are not always returned by the above preg_match. How about suppressing errors in that eval (see attached patch, query_error_suppress.patch)? If suppressing errors is not preferred, how about lowering the error_handling at that point to ignore Notices (see attached patch, query_notice_ignore.patch)?

I prefer ignoring Notices temporarily, as it allows other errors to be caught and logged.

[simonwheatley]

Query error suppression option

[simonwheatley]

Query notice ignore option

[simonwheatley]

Forgot to add steps to reproduce:

1. Define the constant "WP_DEBUG" in your wp_config.php

2. Access a page in your Wordpress installation

3. (Open the PHP error log if you're not tailing it)

4. See the Notice, similar to:

Notice:Undefined offset: 2 in /Users/simon/Projects/WordPress-2.5/site/wp-includes/classes.php(111) : eval()'d code:1

[ryan]

Milestone 2.5.2 deleted

[Denis-de-Bernardy]

see also: #9602

[Denis-de-Bernardy]

why not add isset() statements as needed?

[dd32]

why not add isset() statements as needed?

...I'm not sure that'll work..

What i'm more interested in however, is what rewrite rule is throwing the noticed (If its still even current), In reality, if the rewrite rule is being matched, but not returning anything, then a few more specific rules are probably needed before the main one.. it results in simpler rules as well as not having this problem..

Is this still current? I've never seen any notices of the such under core trunk without any dodgy plugins.

[hakre]

At least steps to reproduce are needed.

[Denis-de-Bernardy]

fixed along with #9602, no?

[azaozz]

Yes, think so.