Make WordPress Core

Opened 10 years ago

Closed 9 years ago

#6703 closed defect (bug) (invalid)

Insert into post fails: The media window is cleared in Firefox

Reported by: bazil749 Owned by:
Milestone: Priority: normal
Severity: major Version: 2.8
Component: Media Keywords:
Focuses: Cc:


I have no idea why this is happening, however it only happens on an upgrade. I've updated 3 blogs and this problem happens on 2 out of the three. I have disabled ALL plugins, replace all the files again (just in case some corruption happened), but nothing works. Using Firebug, this is error I caught in the console:

uncaught exception: Permission denied to get property Window.send_to_editor Line 0

IE 7 doesn't even get that far. There's a Javascript error in the call to media-upload.php line 136 when the media window is just opened. I can't insert any media.

Attachments (1)

6703.patch (434 bytes) - added by hakre 9 years ago.
Fix for Uploader -> after html-upload got to gallery.

Download all attachments as: .zip

Change History (17)

#1 @tellyworth
10 years ago

I've seen this happen with frameset domain forwarders. Does the domain of the URL in your browser's nav bar when you're on the Write Post page match the one in your WordPress address (Settings/general)?

#2 @ryan
10 years ago

  • Milestone changed from 2.5.2 to 2.9

Milestone 2.5.2 deleted

#3 @warrenpatterson
10 years ago

  • Version changed from 2.5 to 2.6

I am having the exact same problem. I was using 2.5.1 and it was working perfectly. I upgraded to 2.6, copied files again just in case, etc. I get the same behavior. I then downgraded back to 2.5.1 but my same behavior remains...so I am out of luck. Is there any progress in solving this issue?

#4 @mrmist
9 years ago

  • Milestone 2.9 deleted
  • Priority changed from high to normal
  • Resolution set to worksforme
  • Severity changed from major to normal
  • Status changed from new to closed

Closing as worksforme. Reopen if this is still a problem in 2.7.

#5 @doorbells29
9 years ago

  • Resolution worksforme deleted
  • Severity changed from normal to major
  • Status changed from closed to reopened
  • Version changed from 2.6 to 2.7

I'm using 2.7 and I'm having this problem. Works fine in Safari, but totally buggy in FF.

#6 @hakre
9 years ago

What you describe looks like a failed upgrade. You were not able to properly remove the old files from the server before copying the new ones on it. Please do not overrite files while updating! Remove the old files including all directories and copy over the new ones. This is especially important for the javascript stuff. Do not forget to clear your Browsers Cache. Better then: Disable it completely for Testing.

To all who reported: Can anyone of you reproduce this with the browsers caching switched off?

#7 @Denis-de-Bernardy
9 years ago

  • Resolution set to worksforme
  • Status changed from reopened to closed

+1 to hakre's suggestion that it's a failed upgrade. please reopen after trying hakre's suggestion

#8 @hakre
9 years ago

  • Resolution worksforme deleted
  • Status changed from closed to reopened
  • Version changed from 2.7 to 2.8

I experience something that might be realted. It is the following:

After uploading a File with the uploader in the lighbox the frames content becomes blank.

With earlier Versions of Wordpress I was forwarded to the Gallery tab.

I even found a way to isolate, that is just directly calling the frames content:

I do not get javascript errors. Tested with a switched off cache.

but i do not have a failed upgrade here, this is a fresh test system.... o_O

#9 @hakre
9 years ago

function media_upload_form_handler() in media.php misses docblocks.

#10 @hakre
9 years ago

  • Component changed from General to Media
  • Keywords needs-patch added
  • Milestone set to 2.8

looks like a redirect is missing here.

#11 @hakre
9 years ago

  • Keywords 2nd-opinion added

9 years ago

Fix for Uploader -> after html-upload got to gallery.

#12 follow-up: @hakre
9 years ago

this fixes or at least it takes me to the gallery page. might be a better idea to come back to the form with the attachments data displayed or have that opened in the gallery. no idea really i'm not so into it.

think as well that this (old) ticket was taling about something else. i wait for some feedback and maybe i open a fresh new ticket.

#13 in reply to: ↑ 12 @azaozz
9 years ago

Replying to hakre:

think as well that this (old) ticket was taling about something else.

Yes, this ticket seems to be talking about triggering the "same domain policy" exception in js when there's mismatch between what is set in the "WordPress address (URL)' option and the actual URL. There is a fix for this but it could open the uploader to XSS attacks. Seems that more research is needed to address this.

The automatic redirect to the Gallery tab after files have been uploaded was removed some time ago to allow the user to add title and description to the just uploaded files. It redirects when the "Save all" button is clicked.

#14 @hakre
9 years ago

thanks for clarification. my problem when not having the patch is, that there is nothing displayed at all - uploading leeds to a blank iframe. double checked for errors while writing the patch, so please lead me the way.

#15 @hakre
9 years ago

Re-tested with latest Trunk in FF: works now.

#16 @hakre
9 years ago

  • Keywords needs-patch 2nd-opinion removed
  • Milestone 2.8 deleted
  • Resolution set to invalid
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.