WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#6710 closed defect (bug) (invalid)

Alignment classes from image insert

Reported by: matt Owned by: andy
Milestone: Priority: high
Severity: normal Version: 2.5
Component: Administration Keywords:
Focuses: Cc:

Description

The align classes we insert from the image uploader seem to have no impact in the WYSIWYG or default theme. Lame.

Secondly, there is no reason to have an "alignnone" class, if there's no alignment, just don't put a class.

Change History (7)

comment:1 @matt7 years ago

  • Milestone changed from 2.7 to 2.5.1
  • Version set to 2.5

comment:2 follow-up: @Viper007Bond7 years ago

"alignnone" doesn't hurt and I'm sure there's some situation where a user would want to style an image if it's not floated. It's easier to just use the "alignnone" class to do those specific stylings rather than applying it to all images and then undoing it fro alignleft, right, etc.

comment:3 @azaozz7 years ago

The classes for aligning images and the extension to the Align buttons for the WYSIWYG (that would allow the user to change the class after inserting images) are in #6645.

comment:4 @azaozz7 years ago

Matt, Andy, are we keeping the "alignnone" class for images that are not aligned? If yes, will have to add it to the alignment buttons in TinyMCE, so when an image is inserted as aligned and then the alignment is removed in the editor, it adds "alignnone" too, so it's fully consistent with the Media Library.

comment:5 in reply to: ↑ 2 @djr7 years ago

Replying to Viper007Bond:

"alignnone" doesn't hurt and I'm sure there's some situation where a user would want to style an image if it's not floated. It's easier to just use the "alignnone" class to do those specific stylings rather than applying it to all images and then undoing it fro alignleft, right, etc.

Agreeing with Viper007Bond! I use 'alignnone' for this specific reason (adding some padding and a border) without it affecting all my other images. +1 for keeping alignnone.

comment:6 @ryan7 years ago

  • Milestone changed from 2.5.2 to 2.9

Milestone 2.5.2 deleted

comment:7 @Denis-de-Bernardy6 years ago

  • Milestone 2.9 deleted
  • Resolution set to invalid
  • Status changed from new to closed

Closing this as invalid. I agree the alignnone class should be kept too. And the images are aligned in the wysiwyg editor.

Note: See TracTickets for help on using tickets.