image_send_to_editor is called twice for every image

[AaronCampbell]

Inside the get_image_send_to_editor function in wp-admin/includes/media.php, first get_image_tag is called, which applies the filter image_send_to_editor, then later in that same function the image_send_to_editor filter is applied again. I'm adding image captioning, so I need to modify the image code sent to the editor, but not the image tag. We should change the call inside get_image_tag to be "get_image_tag" rather than "image_send_to_editor"

Patch Attached.

[ryan]

(In [7838]) Don't reuse image_send_to_editor filter in get_image_tag(). Props AaronCampbell. fixes #6806 for trunk

[ryan]

(In [7839]) Don't reuse image_send_to_editor filter in get_image_tag(). Props AaronCampbell. fixes #6806 for 2.5

[ryan]

Milestone 2.5.2 deleted