Opened 17 years ago
Closed 17 years ago
#6811 closed enhancement (fixed)
Unify TinyMCE image popup and insert image popup
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.6.1 | Priority: | normal |
Severity: | normal | Version: | 2.5 |
Component: | Administration | Keywords: | blessed |
Focuses: | Cc: |
Description
Right now we have two methods for interacting with images, one bundled with TinyMCE and one from our "insert image" dialog.
Our insert image dialog has some better functionality around alignment and such, so we should standardize on that.
Attachments (6)
Change History (20)
#2
@
17 years ago
Customized Edit Image dialog, first run. Has the functionality of both "Insert/Edit Image" and "Insert/Edit Link" popups in TinyMCE, together with several WordPress specific features (css classes, attachment rel, etc.). Also the look and feel is like the Add Media dialog.
Has an advanced tab that may need some options added or removed.
The zip file contains a TinyMCE plugin that goes to /wp-includes/js/tinymce/plugins/.
#4
follow-up:
↓ 5
@
17 years ago
I think some strings in the plugin need to be setup for translation.
#5
in reply to:
↑ 4
@
17 years ago
Replying to ryan:
I think some strings in the plugin need to be setup for translation.
Yes, the translation strings aren't in yet. Was wondering if this should be integrated with the "Add external image" too.
#6
@
17 years ago
Second run. Added translation strings, RTL support, several layout improvements, image border, hspace and vspace can be used as shortcuts to add css styles, the preview is visible on both tabs, etc.
Also made a small change to ThickBox' style for the loading animation, now it's shown in a box similarly to the theme preview on http://wordpress.com.
#8
@
17 years ago
The edit-image-popup2.patch includes a new file:
wp-includes/js/tinymce/plugins/wpeditimage/css/editimage-rtl.css
that didn't get created for some reason. Adding a zipped version of it.
#10
@
17 years ago
Fixes: align center in IE, import of color css stylesheets, potential error on submit when removing align center, few css fixes, etc. The image size setting is now on the side and is in percents of the current size.
#12
@
17 years ago
Several fixes: new link not created if the image has class "aligncenter" in Safari; recalculates the demo image size properly and applies any inline styles to it; if relative link is added, it's converted to absolute; "Unknown error" in IE6, although everything is working well.
See also: #6812.