WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#6813 closed enhancement (fixed)

Press This bookmarklet - quick posting from around the web

Reported by: matt Owned by: ryan
Milestone: 2.6 Priority: high
Severity: normal Version: 2.5
Component: Administration Keywords: blessed
Focuses: Cc:

Description

We've had a bookmarklet since WordPress 1.0, it used to be a popup, then we had a sidebar thing, then a redirect to the standard post interface. I think there are some really good examples of a nice quick post interaction that doesn't bounce you off the page. There's a good plugin already:

http://web.twelvehorses.com/projects/quickpost/

If you know of any other examples add them as comments.

Attachments (26)

quick-post.diff (26.0 KB) - added by ryan 6 years ago.
tab.png (734 bytes) - added by ryan 6 years ago.
quick-post-mce.patch (5.3 KB) - added by azaozz 6 years ago.
press-this-noel-6-16-08.diff (7.9 KB) - added by noel 6 years ago.
June 16 5:39pm
loading-publish.gif (1.8 KB) - added by noel 6 years ago.
wp-admin/images/ is the correct path for this file.
press-this-6-18-08-5am.diff (9.6 KB) - added by noel 6 years ago.
Fixes for unicode/ascii/apostrophe problems. Upgrades to the Photo tab.
press-this-6-18-08-3pm.diff (9.5 KB) - added by noel 6 years ago.
(merge arrows fixed) Fixes for unicode/ascii/apostrophe problems. Upgrades to the Photo tab.
press-this-6-19-9pm.diff (1.1 KB) - added by noel 6 years ago.
press this photo tab fixes.
media-6-23-1am.diff (2.2 KB) - added by noel 6 years ago.
Press this fixes for media.php dealing with wp_error object
press-this-6-23-1am.diff (2.5 KB) - added by noel 6 years ago.
Fixes corresponding with wp_error object issues - this negates the was patched from rev 8166 (negates 6-19 patch)
press-this-6-23-4am.diff (18.4 KB) - added by noel 6 years ago.
This patch fixes problems with wp_error the photo tab and some js issues dealing with cross-browser implementation.
press-this-fixes-hotlinking-6-23-5pm.diff (2.9 KB) - added by noel 6 years ago.
High Priority! Fixes image uploading hotlinking issue.
press-this-sideload-querystringfix.diff (627 bytes) - added by noel 6 years ago.
Query String fix for file.php
press-this-media-handling-6-26.diff (357 bytes) - added by noel 6 years ago.
Fix for image uploader that was adding http:// for no reason.
press-this-7-2-4am.diff (458 bytes) - added by noel 6 years ago.
Escape quotes in titles.
press-this_0704.patch (4.3 KB) - added by azaozz 6 years ago.
press-this_7-9-5pm.diff (16.0 KB) - added by noel 6 years ago.
CSS cleanup, photo input newline breaks, fixes short_tags problem
press-this_7-10-9pm.diff (811 bytes) - added by noel 6 years ago.
Fixes continuous linking issue by using rlm entity;
press-this-ie.css (96 bytes) - added by noel 6 years ago.
wp-admin/css/ IE stylesheet
press-this_7-11-1am.diff (1.2 KB) - added by noel 6 years ago.
IE CSS stylesheet conditional comment
pess-this-selection-fix.patch (17.7 KB) - added by azaozz 6 years ago.
Fixes inserting the selection in the editor and stripping of paragraphs when saving.
press-this-combined_7-11.patch (20.3 KB) - added by noel 6 years ago.
Combined patches from azaozz and noel.
pess-this-content-fix.patch (2.2 KB) - added by azaozz 6 years ago.
press-this-20080712.patch (3.2 KB) - added by azaozz 6 years ago.
press-this-ie.2.css (113 bytes) - added by azaozz 6 years ago.
press-this_7-14.patch (529 bytes) - added by noel 6 years ago.
Fixes issue with Flickr and some other url variations

Download all attachments as: .zip

Change History (79)

ryan6 years ago

comment:2 ryan6 years ago

Patch uses the QuickPost plugin as a base. Ported it to latest ui.tabs, added gettext, switched to use script loader and wp_category_checklist(), and changed to WP code formatting. It still needs some love, but this is a good start. The shortcut link is in the postbox on the Write->Post page.

ryan6 years ago

comment:3 ryan6 years ago

(In [7919]) Quick post bookmarklet. First cut. see #6813

azaozz6 years ago

comment:4 azaozz6 years ago

Some fixes for TinyMCE: added the new theme, languages, support for Safari, modal dialogs, changed some settings to be the same like the write page, small css fixes, etc.

comment:5 ryan6 years ago

(In [7923]) Quick post TMCE improvements: add new theme, languages, support for Safari, modal dialogs, changed some settings to be the same like the write page, small css fixes. Props azaozz. see #6813

comment:6 ryan6 years ago

(In [7924]) Quick post updates: More gettext, escaping, compress bookmarklet JS. see #6813

comment:7 ryan6 years ago

(In [7927]) Don't pass image list via GET. Fetch images remotely. Load photo tab via AJAX. see #6813

comment:9 ryan6 years ago

(In [7931]) Brand as Press This. see #6813

comment:10 ryan6 years ago

(In [7933]) Only img src. see #6813

comment:11 ryan6 years ago

(In [7934]) Press This: Fetch offsite images, fix slashing. see #6813

comment:12 ryan6 years ago

(In [7945]) Some escaping. see #6813

comment:14 ryan6 years ago

  • Summary changed from Viva la bookmarklet - quick posting from around the web to Press This bookmarklet - quick posting from around the web

comment:15 ryan6 years ago

#7120 rearranges UI to put tags on the right. I'm not too crazy about that. I think we need to go through each tab and make some UI decisions.

comment:16 ryan6 years ago

(In [8071]) Press This UI changes and photo loading fixes from noel. fixes #7120 see #6813

comment:17 ryan6 years ago

(In [8093]) Press this updates from noel. see #6813

comment:19 noel6 years ago

  • Owner changed from matt to ryan

Updates are now going in this ticket.

The latest patch fixes problems with paragraphs being transmitted through instead of just line breaks.

I've also attached the loading-publish.gif.

There is still a problem displaying apostrophes despite coming through clean. (?)

Example. Select "it's" in a webpage, click Press This, you'll now get "it\'s". Publish that post and you'll then get "it's" as you should. Anyone? Bueller?

noel6 years ago

June 16 5:39pm

noel6 years ago

wp-admin/images/ is the correct path for this file.

comment:20 ryan6 years ago

(In [8113]) Press This changes from noel. see #6813

comment:21 ryan6 years ago

Looks like selection doesn't get the stripslashes() treatment. js_escape() strips and readds the slashes. I'm not sure we need js_escape() there. It's meant more for js included in onclicks and other attributes.

comment:22 noel6 years ago

I talked with Andrew and seem to have it all figured out now. Another patch to fix the apostrophe/encoding oddities is coming soon.

noel6 years ago

Fixes for unicode/ascii/apostrophe problems. Upgrades to the Photo tab.

comment:23 noel6 years ago

The latest attachment should be a big help. No more problems with Japanese/Hebrew or apostrophe issues. *crosses fingers*

The photo tab also got a nice upgrade to add a photo by URL and resizing the content area for the new photos added (this may need some more testing, but seems well enough for use in popular browsers).

comment:24 ryan6 years ago

Looks like some merge arrows snuck into the css.

noel6 years ago

(merge arrows fixed) Fixes for unicode/ascii/apostrophe problems. Upgrades to the Photo tab.

comment:25 noel6 years ago

Sorry for being forgetting the merge arrows Ryan! All fixed.

comment:26 noel6 years ago

And for misunderstanding the english language in my last reply ;)

comment:27 ryan6 years ago

(In [8128]) Press This: Fixes for unicode/ascii/apostrophe problems. Upgrades to the Photo tab. Props noel. see #6813

noel6 years ago

press this photo tab fixes.

comment:28 noel6 years ago

  • Priority changed from normal to high

noel6 years ago

Press this fixes for media.php dealing with wp_error object

noel6 years ago

Fixes corresponding with wp_error object issues - this negates the was patched from rev 8166 (negates 6-19 patch)

noel6 years ago

This patch fixes problems with wp_error the photo tab and some js issues dealing with cross-browser implementation.

comment:29 noel6 years ago

press-this-6-23-4am.diff should be the patch used.

Ignore press-this-6-23-1am.diff, media-6-23-1am.diff, and press-this-6-19-9pm.diff (if not already applied) since the latest patch contains all of those changes (since I diffed against trunk).

comment:30 ryan6 years ago

(In [8169]) Press This updates from noel. see #6813

comment:31 noel6 years ago

Photo tab has begun hotlinking. I'm working on clarifying this issue and getting a patch out asap.

noel6 years ago

High Priority! Fixes image uploading hotlinking issue.

comment:32 noel6 years ago

Patch attached that fixes hotlinking issues.

comment:33 ryan6 years ago

(In [8172]) Press This image linking fixes from noel. see #6813

comment:34 noel6 years ago

Press This was having problems with sideloading images with query strings. A simple fix is attached.

noel6 years ago

Query String fix for file.php

comment:35 ryan6 years ago

(In [8192]) Image sideloader fix from noel. see #6813

noel6 years ago

Fix for image uploader that was adding http:// for no reason.

comment:36 ryan6 years ago

(In [8201]) Don't prepend http. Props noel. see #6813

noel6 years ago

Escape quotes in titles.

comment:37 azaozz6 years ago

Was thinking to change TinyMCE to be compressed when loaded in Press This, but since it only loads 3 js files, it's faster to cache them with Gears instead.

The patch also includes few small css fixes:

  • Removed width="475" from the image preview in ThickBox. Small images look quite bad with it. If scaling-down is needed, the images can be resized with 2 lines of js.
  • Changed the "Insert Image" and "Cancel" links to look more consistent.

While testing, Press This seems to have some problems:

  • If there is a selection on the page, all of it is inserted as a link in the editor.
  • If the selection is across two paragraphs, the encoding of the string seems wrong and breaks the editor.
  • The popup doesn't open in IE6 and opens in the main window in IE7 if the site doesn't have permission to show popups.
  • The layout is broken in IE7. May need to make/load specific css for IE.

azaozz6 years ago

comment:38 ryan6 years ago

(In [8256]) Gears and styling updates for Press This from azaozz. see #6813

noel6 years ago

CSS cleanup, photo input newline breaks, fixes short_tags problem

comment:39 ryan6 years ago

(In [8303]) Press This: CSS cleanup, photo input newline breaks, fixes short_tags problem. Props noel. see #6813

noel6 years ago

Fixes continuous linking issue by using rlm entity;

comment:40 noel6 years ago

IE css fixes are almost complete.

noel6 years ago

wp-admin/css/ IE stylesheet

noel6 years ago

IE CSS stylesheet conditional comment

azaozz6 years ago

Fixes inserting the selection in the editor and stripping of paragraphs when saving.

comment:41 paulhontz6 years ago

Does this also include a link back to the original article?

comment:42 ryan6 years ago

Can I get a cumulative patch with all of these changes in it.

Also, can the IE stylesheet be loaded via the style loader so that gears will know about it?

comment:43 ryan6 years ago

paulhontz, do you mean in the text tab? I think we don't link back in the Text tab if a selection is being passed, which is the way Tumblr and some others behave, IIRC. We should provide a link back for the Quote tab, however. I'm open to adding a link back to the Text tab though.

comment:44 paulhontz6 years ago

I think adding a link on the text tab would be a very beneficial feature. If you come across a cool article, I think it would be more kind to the original author if you took an excerpt, and automatically had a link back to his site (where the content originated).

thanks ryan!

comment:45 paulhontz6 years ago

I think it would also make a great addition to any tab.

For example:

[Picture you selected]
"Content content content content"
url link back

I think this would make a lot of sense. Also, is it possible to pass highlighted pictures through the bookmarklet?

noel6 years ago

Combined patches from azaozz and noel.

comment:46 ryan6 years ago

(In [8316]) Press This: Fix inserting the selection in the editor and stripping of paragraphs when saving, IE CSS styling fixes, fix continuous linking in editor. Props noel and azaozz. see #6813

comment:47 azaozz6 years ago

Switching to using our default content cleanup in the editor. Tried it for the patch yesterday, but didn't work in IE. Turns out the IE on my computer was having problems, not the code.

comment:48 ryan6 years ago

(In [8318]) Press This: Switching to using our default content cleanup in the editor. Props azaozz. see #6813

azaozz6 years ago

azaozz6 years ago

comment:49 azaozz6 years ago

Few small fixes: properly add and load press-this-ie.css, cleanup of the bookmarklet code.

comment:50 ryan6 years ago

(In [8323]) Press This: properly add and load press-this-ie.css, cleanup of the bookmarklet code. Props azaozz. see #6813

comment:51 ryan6 years ago

(In [8330]) rlm entity not so Windows friendly. Use perios instead. see #6813

noel6 years ago

Fixes issue with Flickr and some other url variations

comment:52 ryan6 years ago

(In [8332]) Image regex fixes from noel. see #6813

comment:53 ryan6 years ago

  • Milestone changed from 2.9 to 2.6
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.