More descriptive create directory/copy errors in file.php

[plankers]

When using the plugin updater it would be helpful if the error messages indicated what directory the operation was acting on, so that if there are permission errors they can be more easily resolved.

The affected code are lines 262 and 268 of wp-admin/includes/file.php, and a patch is attached.

[plankers]

Patch for more verbose errors for plugin updater

[DD32]

You cannot use Variables within translate functions( (), _e() )

Instead you need to use things such as:{{{
return new WP_Error('mkdir_failed', sprintf(('Could not create directory: %s', $to . $tmppath));
}}
(Thats just an example).

Another option is to pass the error data along with the WP Error:

return new WP_Error('mkdir_failed', __('Could not create directory'), $to . $tmppath ); 

The updater message will show "Could not create directory: $errordata"

I agree that it needs to be a bit more verbose.

[DD32]

Just a quick note, I've been changing a few of the functions over to utilise WP_Error, But most of them are in file.php, So right now i'm awaiting to see the outcome of #6465 as the changes have been applied to the same install, and any patch will conflict.

[westi]

New patch needed.

[DD32]

New patch needed.

I believe its been implemented in one of my other patches: ​http://trac.wordpress.org/browser/trunk/wp-admin/includes/file.php#L546

However, I'm not sure if its shown upstream in the show_message() function yet.

[westi]

Looks like show_message pulls that data out.

Marking as Fixed.