WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#6859 closed defect (bug) (fixed)

Missing label associations throughout WordPress

Reported by: MarcoZ Owned by: MarcoZ
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.5.1
Component: General Keywords: has-patch tested
Focuses: Cc:

Description

There are several instances throughout WordPress where there are no proper associations between labels and their corresponding form fields.

Attachments (10)

wp-6859.diff (60.5 KB) - added by MarcoZ 6 years ago.
Updated patch, removes inline styles and uses proper CSS styling instead.
wp-6859-2.diff (60.8 KB) - added by MarcoZ 6 years ago.
Removes styling on fieldsets
wp-6859-3.diff (60.9 KB) - added by MarcoZ 6 years ago.
Giving the fieldsets a height, padding, and margin of 0 in addition to a border of 0.
wp-6859-4.diff (66.1 KB) - added by MarcoZ 6 years ago.
1. All closable boxes have their heading label link removed from previous patch, and a hidden label has been added.
wp-6859-5.diff (66.1 KB) - added by MarcoZ 6 years ago.
Remove height: 0; from the fieldset styling to fix visual issues. Thanks rmccue for helping test this one from the visual side and for the reviews!
wp-6859-6.diff (66.2 KB) - added by MarcoZ 6 years ago.
Also work with a hidden label on "Tags" to be consistent. Also, was pointing to wrong input ID.
wp-6859-7.diff (66.2 KB) - added by MarcoZ 6 years ago.
Update to trunk, resolve conflict in wp-admin/wp-admin.css. Otherwise unchanged.
wp-6859-8.diff (67.2 KB) - added by MarcoZ 6 years ago.
Also correct label for "new category" field.
wp-6859-9.diff (70.8 KB) - added by MarcoZ 6 years ago.
Added labels for wp_dropdown_* generated dropdown lists.
wp-6859-10.diff (71.3 KB) - added by MarcoZ 6 years ago.
Updated to Trunk, added hidden fieldset for new avatar feature.

Download all attachments as: .zip

Change History (17)

comment:1 MarcoZ6 years ago

  • Status changed from new to assigned

Taking this ticket.

comment:2 MarcoZ6 years ago

  • Keywords has-patch added

MarcoZ6 years ago

Updated patch, removes inline styles and uses proper CSS styling instead.

MarcoZ6 years ago

Removes styling on fieldsets

MarcoZ6 years ago

Giving the fieldsets a height, padding, and margin of 0 in addition to a border of 0.

comment:3 rmccue6 years ago

  • Keywords tested added; has-patch removed

Tested 3rd patch in FF2 and Safari against r7840. All works as advertised on the box.

MarcoZ6 years ago

  1. All closable boxes have their heading label link removed from previous patch, and a hidden label has been added.

comment:4 MarcoZ6 years ago

  • Keywords has-patch added; tested removed
  1. Fixed up the labels for the new custom field and the key/value pairs in the Custom Fields box. Had to use hidden labels, since there is no way without ARIA (Accessible Rich Internet Applications) to link the several fields to the header. In table navigation mode, it would be picked up, but when filling out forms, hidden labels have to be used.
  2. Reworked how fieldsets are exposed. Now, the fieldset is only present within the cell the form fields that are to be grouped are in. Firefox would otherwise create a grouping outside the table, since it does not allow a fieldset to spawn multiple table cells. To not cause any layout problems, the legend is hidden, but is still picked up by screen readers. Also tested in IE. Please see if this also works correct in Safari!

MarcoZ6 years ago

Remove height: 0; from the fieldset styling to fix visual issues. Thanks rmccue for helping test this one from the visual side and for the reviews!

MarcoZ6 years ago

Also work with a hidden label on "Tags" to be consistent. Also, was pointing to wrong input ID.

MarcoZ6 years ago

Update to trunk, resolve conflict in wp-admin/wp-admin.css. Otherwise unchanged.

MarcoZ6 years ago

Also correct label for "new category" field.

MarcoZ6 years ago

Added labels for wp_dropdown_* generated dropdown lists.

MarcoZ6 years ago

Updated to Trunk, added hidden fieldset for new avatar feature.

comment:5 rmccue6 years ago

  • Keywords tested added

Tested on r7879, on FF2 and Safari. All good to go.

comment:6 westi6 years ago

  • Milestone changed from 2.5.2 to 2.6

Wow. Thats a big patch :-) Good work.

Not sure this is 2.5.2 material really - think it is best to wait for 2.6.

comment:7 westi6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [7883]) Associate lables with form fields. Fixes #6859 props MarcoZ.

Note: See TracTickets for help on using tickets.