Thickbox Should Not Close When Clicked Outside Of Window (while uploading)

[intoxination]

When you click on the overlay, Thickbox will close, which is the desirable function of Thickbox. This should be prevented while an upload is in progress though. Perhaps adding:

jQuery("#TB_overlay").unbind("click",tb_remove);

When the upload starts and then once the upload finishes call:

jQuery("#TB_overlay").click(tb_remove);

Would be a good working method to fix this. Of course the uploader iFrame would have to call this method from the opener window, since Thickbox is instanced from there.

[tellyworth]

Sounds fair to me. Also related: when multiple uploads are in progress, it's possible to stop them by clicking Insert Into Post on the first one. Those buttons (and perhaps the whole Show detail sliding whatsit) should be disabled while other uploads are in progress, in the same way you've suggested above.

And just in case it comes up: under normal circumstances the Thickbox should definitely close when you click outside its box.

[azaozz]

This is a good idea but perhaps we should replace Thickbox as it's no longer supported. Better to fix together with the rest of the media improvements in 2.9.

[azaozz]

Moving to 3.0 pending replacement of Thickbox.

[hakre]

I'll pick up the ground initiative and created a first patch.

[azaozz]

Don't think we need to modify thickbox.js in order to do this.

[azaozz]

(In [12554]) Don't close thickbox when clicking outside the iframe while uploading, fixes #6883

[hakre]

Replying to azaozz:

Don't think we need to modify thickbox.js in order to do this.

With all tests I did I needed to otherwise the unbind did not work. Have you tested your code?

[hakre]

Nevermind, tested it, commited code works properly. Maybe because I did not put topWin in a global var.

[azaozz]

See [12634].