WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#6986 closed defect (bug) (fixed)

Plugin Automatic Update via FTP - SLL option will not deactivate once activated

Reported by: carltonbale Owned by:
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.5.1
Component: Administration Keywords: plugin automatic upgrade FTP SSL has-patch commit
Focuses: Cc:

Description

In WordPress 2.5.0 and 2.5.1, plugin automatic update was working properly via FTP. I then decided to try the FTP SSL option and received the error message

"Error: There was an error connecting to the server, Please verify the settings are correct."

So apparently my server does not support FTP over SSL. So I disabled the SSL option by setting "Use SSL" to "No". However, I continued to receive the same connection error message as above. The message would appear no matter what was entered into the FTP configuration page.

I finally added the following line to my wp-config.php file:

define('FTP_SSL', false);

This caused the SSL setting within the plugin FTP updater to be overwritten with the correct value. FTP updates of plugins began to again function properly after making this change.

Attachments (1)

6986.diff (1.0 KB) - added by DD32 6 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 DD326 years ago

This is due to a rather anoying thing with PHP:

$string = "0";
var_dump( empty($string) ); = true
}}
A string with only a 0 is classified as an empty string.

Attached patch sets it based on if the item was post'd along or not.

DD326 years ago

comment:2 DD326 years ago

  • Keywords has-patch commit added

comment:3 ryan6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [7949]) Fix FTP SSL setting. Props DD32. fixes #6986 for trunk

comment:4 ryan6 years ago

(In [7950]) Fix FTP SSL setting. Props DD32. fixes #6986 for 2.5

comment:5 ryan6 years ago

  • Milestone changed from 2.5.2 to 2.9

Milestone 2.5.2 deleted

comment:6 westi6 years ago

  • Milestone changed from 2.9 to 2.6
Note: See TracTickets for help on using tickets.