get_post_custom() doesn't always return an array

[donncha]

I have noticed that get_post_custom() doesn't always return an array. wp-includes/feed.php uses this function in a foreach loop at line 164 in WP 2.5.1 resulting in an error message stating "Invalid argument supplied for foreach() in ...wp-includes/feed.php on line 164"

I think update_postmeta_cache() in wp-includes/post.php should cast it's return value as an array possibly.

[donncha]

Casting the return of get_post_custom() as an array fixes this problem.

[ryan]

Milestone 2.5.2 deleted

[Denis-de-Bernardy]

seems invalid:

	foreach ( (array) $ids as $id ) {
		if ( ! isset($cache[$id]) )
			$cache[$id] = array();
	}

	foreach ( (array) array_keys($cache) as $post)
		wp_cache_set($post, $cache[$post], 'post_meta');

or am I missing something?

[Denis-de-Bernardy]

returns an array even with a non-existing post.