get_post_ancestors() is broken

[temoto]

wp-includes/post.php:195
Bugs:

• Params description do not match code.
  
• Function doesn't work because get_post() requires argument.

/**
 * get_post_ancestors() - Retrieve ancestors for a post
 *
 * @package WordPress
 * @subpackage Post
 * @since 2.5
 *
 * @param string $field {@internal Missing Description}}
 * @param int|object &$post post ID or post object
 * @return array of ancestor IDs
 */
function get_post_ancestors($post) {
	$post = get_post();

	if ( !empty($post->ancestors) )
		return $post->ancestors;

	return array();
}

[Otto42]

I think this would fix it:

function get_post_ancestors($post) {
	if (is_integer($post)) $post = get_post($post);

	if ( !empty($post->ancestors) )
		return $post->ancestors;

	return array();
}

[mdawaffe]

get_post() can take post IDs or post object, (or be told to get the global $post by passing it 0).

Attached. I think the argument to get_post_ancestors() should not be a reference, but I'm not positive.

[ryan]

(In [8019]) get_post_ancestors() fixes. fixes #7029 for trunk

[ryan]

(In [8020]) get_post_ancestors() fixes. fixes #7029 for 2.5

[ryan]

Milestone 2.5.2 deleted