get_tag_feed_link() doesn't add slash

[scribu]

This error occurs when (almost) pretty permalinks are used and there is no trailing slash: get_tag_feed_link() doesn't add a slash before 'feed'.

Example:

Permalink struncture: /%category%/%postname%.html

Tag url: ​http://example.com/tag_base/tag

Tag feed: ​http://example.com/tag_base/tagfeed

[Viper007Bond]

Add a trailing slash to your permalink structure at Settings -> Permalinks. WordPress (including get_tag_feed_link()) generates URLs based on your preference set there.

[Viper007Bond]

And if you wish to use a structure without a trailing slash (as you are with .html), you'll just need to add the slash manually when you want a trailing slash.

[DD32]

I dont agree with that Viper007Bond.

You are correct that it uses that, And if you want a slash on the end of the url, then it needs to be set

However, In the permalink structure given, you do not want a trailing slash, and you do want a slash before any suffix's which are applied.

Ie. In this case, The missing slash is: Tag feed: ​http://example.com/tag_base/tag'''/'''feed

[scribu]

I agree with DD32, and would like to mention that get_category_feed_link() works without a trailing slash in the permalink structure.

[Viper007Bond]

Replying to DD32:

You are correct that it uses that, And if you want a slash on the end of the url, then it needs to be set

However, In the permalink structure given, you do not want a trailing slash, and you do want a slash before any suffix's which are applied.

Oh, I'm sorry. I misread the ticket. I thought he was talking about the very end slash.

You're completely right. It should trailingslashit() rather than the "maybe" version.

My apologies.

[guillep2k]

Please don't add my name to Cc: without at least a word on what do you expect from me. Thanks.

[ryan]

(In [8000]) Fix slashing in tag feed link. fixes #7044 for trunk

[ryan]

(In [8001]) Fix slashing in tag feed link. fixes #7044 for 2.5

[ryan]

Milestone 2.5.2 deleted