Delete blacklisted comments rather than mark them as spam

[donncha]

Comments that are blacklisted because of the Blacklist keys on options-discussion.php should be deleted immediately instead of being marked as spam. Patch attached.

[donncha]

Patch for wp-includes/comment.php

[mdawaffe]

This seems like a pretty big change. Can you say why blacklist matching comments should be deleted?

I have "casino" in my blacklist, but if I ever write a post about going to Vegas, I don't want all the comments to get deleted.

[Viper007Bond]

Yeah, I think spam is best. Allows for recovery.

[donncha]

This is something Photomatt and Markr wanted. Markr brought it up in conversation with a blogger who is getting lots of stupid comments from one particular user. He added that person's email address or IP into the blacklist expecting the comments to be deleted but instead he had to read the comments in the Akismet spam page and delete them.

They weren't submitted to Akismet so the spam page is probably the wrong page for these comments to be left in.

This is a result of confusion over what the blacklist does. Is it a spam list or stupid list? :)

[Viper007Bond]

Perhaps a new status is in order or something.

It just seems like not having them be instantly deleted would be a good idea incase there was a false positive as mdawaffe mentioned (Vegas).

[ryan]

Milestone 2.5.2 deleted

[Denis-de-Bernardy]

suggesting wontfix, personally.

[nacin]

Perhaps now that we have Trash, that could be where they end up?

[Viper007Bond]

Replying to nacin:

Perhaps now that we have Trash, that could be where they end up?

Strong +1

Allows recovery still and is a better fit. The comments from people on the blacklist aren't necessarily spam, they're just unwanted comments.

[solarissmoke]

Place blacklisted comments in the trash

[chriscct7]

Does someone from core want to quickly review the idea?
Essentially, blacklisted comments are moved to spam instead of trash. Its a simple 2 line patch file, so the only major thing really on this is whether or not blacklisted comments should go to trash or spam (where they currently go). I'm in favor of trash, as blacklisted comments can be non-spam, and they can be unintentionally flagged on the blacklist, but many users might think of all the comments in spam are spam and simply empty the spam folder without thinking.

[MikeHansenMe]

Refreshed

[MikeHansenMe]

I think this makes good sense. Easy patch as well. I do see it causing any issues.

[helen]

What happens when somebody disables trash?

[MikeHansenMe]

If they are being set to trash and the trash is disabled they would be auto deleted. I am not sure if this is something we should account for or expected behavior.

[helen]

Seems like it would be bad if comments started getting auto-deleted now, just because of the destructive/unrecoverable change in behavior.

[Denis-de-Bernardy]

Replying to helen:

Seems like it would be bad if comments started getting auto-deleted now, just because of the destructive/unrecoverable change in behavior.

If someone bothers to disable the trash, wouldn't you agree that this person actually wants that destructive / unrecoverable behavior?

[helen]

Replying to Denis-de-Bernardy:

If someone bothers to disable the trash, wouldn't you agree that this person actually wants that destructive / unrecoverable behavior?

I would not expect an upgrade of WordPress to suddenly cause blacklisted comments to be outright deleted rather than in some moderated state where I could recover them if I wanted to.

[Denis-de-Bernardy]

Replying to helen:

I would not expect an upgrade of WordPress to suddenly cause blacklisted comments to be outright deleted rather than in some moderated state where I could recover them if I wanted to.

I'll let you do what's right then:

https://core.trac.wordpress.org/ticket/7051#comment:7

[helen]

Stepping back a little further to look at the wider view, would it perhaps make more sense to note in comment meta that the comment is in spam because of the blacklist? If it does, then I think we can close this (as documentation that we've had this discussion) and make a new ticket.

[wonderboymusic]

7051.4.diff​ - I really don't care what we do here

[helen]

In 34726:

Comments: Trash blacklisted comments by default.

If trash is disabled, they wil continue to go into spam like they do now.

props wonderboymusic, solarissmoke, MikeHansenMe.
fixes #7051.