WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#7065 closed enhancement (fixed)

Add filter 'image_class' to 'get_image_tag' function in 'wp-includes/media.php'

Reported by: ronalfy Owned by:
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.5.1
Component: General Keywords: has-patch 2nd-opinion
Focuses: Cc:

Description

As referenced in this post, some would like the ability to remove or customize the class attribute in the media manager.

Recommended solution is to add a new filter called 'image_class' to the 'get_image_tag' function in '/wp-includes/media.php'.

Before:

function get_image_tag($id, $alt, $title, $align, $size='medium') {

	list( $img_src, $width, $height ) = image_downsize($id, $size);
	$hwstring = image_hwstring($width, $height);

	$html = '<img src="'.attribute_escape($img_src).'" alt="'.attribute_escape($alt).'" title="'.attribute_escape($title).'" '.$hwstring.'class="align'.attribute_escape($align).' size-'.attribute_escape($size).' wp-image-'.$id.'" />';

	$url = '';
	$html = apply_filters( 'image_send_to_editor', $html, $id, $alt, $title, $align, $url, $size );

	return $html;
}

After:

function get_image_tag($id, $alt, $title, $align, $size='medium') {

	list( $img_src, $width, $height ) = image_downsize($id, $size);
	$hwstring = image_hwstring($width, $height);
	$class = 'align'.attribute_escape($align).' size-'.attribute_escape($size).' wp-image-'.$id;
	$class = apply_filters('image_class', $class, $id, $align, $size);
	$html = '<img src="'.attribute_escape($img_src).'" alt="'.attribute_escape($alt).'" title="'.attribute_escape($title).'" '.$hwstring.'class="'.$class.'" />';

	$html = apply_filters( 'image_send_to_editor', $html, $id, $alt, $title, $align, $url );

	return $html;
}

Code changed is here:

$class = 'align'.attribute_escape($align).' size-'.attribute_escape($size).' wp-image-'.$id;
	$class = apply_filters('image_class', $class, $id, $align, $size);
	$html = '<img src="'.attribute_escape($img_src).'" alt="'.attribute_escape($alt).'" title="'.attribute_escape($title).'" '.$hwstring.'class="'.$class.'" />';

Attachments (2)

media.phpdoc.7065.diff (1.8 KB) - added by jacobsantos 7 years ago.
New filter for get_image_tag() and phpdoc based off of r8027
media.phpdoc.2.5.2.diff (1.8 KB) - added by jacobsantos 7 years ago.
Patch for 2.5 branch based off of r8027

Download all attachments as: .zip

Change History (6)

@jacobsantos7 years ago

New filter for get_image_tag() and phpdoc based off of r8027

comment:1 @jacobsantos7 years ago

  • Keywords has-patch 2nd-opinion added; needs-patch removed
  • Milestone changed from 2.5.2 to 2.6

Patch adds new filter named 'get_image_tag_class' to get_image_tag().

@jacobsantos7 years ago

Patch for 2.5 branch based off of r8027

comment:2 @jacobsantos7 years ago

Added patch for 2.5.x too.

comment:3 @ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [8029]) New filter and phpdoc for get_image_tag(). Props jacobsantos. fixes #7065 for trunk

comment:4 @ryan7 years ago

(In [8030]) New filter and phpdoc for get_image_tag(). Props jacobsantos. fixes #7065 for 2.5

Note: See TracTickets for help on using tickets.