a new WP_Query created in the loop, whose the_post() method is called, messes around with wp_the_query - "recent entries" widget is still loop-breaking

[msi08]

I'm using a "related posts" plugin and I noticed a problem with the ID of the current post when the "recent entries" widget is used as the first widget. I found a solution somewhere in the internet but I'm surprised that it's still not a part of the trunk.

I don't know who to credit for (maybe Google can help), but here is the fix, I found and use.

[Denis-de-Bernardy]

broken patch

[Denis-de-Bernardy]

invalid, given how wp_reset_query() behaves

[Denis-de-Bernardy]

annoyingly, I just ran into this one myself.

[Denis-de-Bernardy]

patch doesn't help much either.

to reproduce, do the following in the loop:

the_title(); the post's title

insert widget here

the_content(); the content of the widget's last post

[Denis-de-Bernardy]

something in there is changing wp_the_query.

[Denis-de-Bernardy]

it's occurring around the_post(), but I can't figure out what it might be.

[Denis-de-Bernardy]

see also #9458

[jacobsantos]

The Recent Posts widget already uses this technique (albeit in a less hackish way).

[jacobsantos]

If there is still a problem, then it is not where you expect it to be.

[jacobsantos]

Nothing is changing wp_the_query. When reset_query is run, then the wp_query is removed and then recreated with what is in wp_the_query. If you are running into problems, then it isn't in anything in the Widget but code outside of it.

[Denis-de-Bernardy]

Jacob, I wouldn't have opened the ticket if it had occurred in trunk. ;-)

[Denis-de-Bernardy]

had not occurred, even. there is *major* bug in wp_reset_query atm. try the procedure I outline above and see for yourself. It *wrecks* everything. insert the recent posts before calling the_content(), you'll see the post's contents turned into the recent widget's last items' contents.

[Denis-de-Bernardy]

also, consider adding this after the call to the_post() in the recent posts widget:

var_dump($GLOBALS['wp_the_query']->post->ID);

you will notice that it changes.

[Denis-de-Bernardy]

merging this into #9854