Link 'Web Address' field strips pipes

[Jairus]

When creating a new (or editing an existing) link, all pipes will be stripped from the Web Address field (but not Name or Description).

Thus, it's impossible to use Links to link to any sites which use pipes in their URL structure, such as:

​http://www.hallmark.com/webapp/wcs/stores/servlet/category3|10001|10051|181568|147551;-102001;181568|ecards|Just%20Because

[Scott H]

Whether this was left out intentionally or not, I don't know. Attached does the trick though.

[ryan]

Milestone 2.5.2 deleted

[jairus]

Is there a reason why this is pushed to 2.9 instead of being patched in sooner?

[mrmist]

Patch is stale. Also if only wp-includes/formatting.php expression is changed, then the resultant pipe symbol gets urlencoded. I'm not sure whether that is the intended result or not. I'd say probably not, so removing has-patch for now.

Can't think of any particular reason why a pipe shouldn't be allowed, though. (It would only seem potentially harmful if prefixed by other harmful stuff.)

[mrmist]

Actually the encoding probably is right, so it would just need refreshing in that case.

[scohoust]

Just tried this patch on r10933 (I submitted the original) and couldn't find any issue. Could you point out where the problem is?

Reuploaded the diff to work with current trunk.

[Denis-de-Bernardy]

confirmed bug. it's in the link manager

[ryan]

Other characters are unsafe because gateways and other transport agents are known to sometimes modify such characters. These characters are "{", "}", "|", "\", "^", "~", "[", "]", and "`".

All unsafe characters must always be encoded within a URL.

​http://www.ietf.org/rfc/rfc1738.txt

Doesn't seem like pipe is marked unsafe for security reasons, so it's probably safe to let it through.

[ryan]

(In [11023]) Allow pipes through clean_url(). Props scohoust. fixes #7145