WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#7165 closed enhancement (fixed)

Allow wp_generate_tag_cloud() to work with other values than get_tags() return.

Reported by: DD32 Owned by:
Milestone: 2.7 Priority: normal
Severity: normal Version: 2.6
Component: Template Keywords: has-patch
Focuses: Cc:

Description

Currently wp_generate_tag_cloud() is hard-coded to utilise get_tags(), Which for the inbuilt tag clouds are fine, But when a plugin, or core wants to use a Tagcloud/heatmap, It needs to create its own function.

The attached patch moves all tag logic back into wp_tag_cloud(), and leaves wp_generate_tag_cloud() mearly generating a tag cloud from the provided data.

Backwards Compatibility: Back Compat. will be broken for anything which relies on a text output from wp_generate_tag_cloud(), Could be implemented at the same time as #5710 (wp_tag_cloud should echo get_tag_cloud)

Attachments (1)

7165.diff (3.1 KB) - added by DD32 6 years ago.
Note: PHPDoc needs completing.

Download all attachments as: .zip

Change History (2)

DD326 years ago

Note: PHPDoc needs completing.

comment:1 DD326 years ago

  • Milestone changed from 2.9 to 2.7
  • Resolution set to fixed
  • Status changed from new to closed
  • Type changed from defect to enhancement

Implemented as part of plugin installer code.

Related Commits:

(In [8540]) Plugin Install GSOC project first code drop. Props DD32 see #6015.
(In [8569]) Fix tag cloud links. Props DD32. see #6015
(In [8666]) Revert tag cloud changes in 8540 and 8569. They broke tag sorting. see #6015
(In [8668]) Tag cloud fixes from DD32. Implements number arg. see #6015

Note: See TracTickets for help on using tickets.