Make WordPress Core

Opened 16 years ago

Closed 16 years ago

#7176 closed enhancement (fixed)

Grammar in Gears Enabled Dialog

Reported by: speedboxer's profile Speedboxer Owned by: westi's profile westi
Milestone: 2.7 Priority: low
Severity: minor Version: 2.6
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

In the Gears enabled and installed dialog box, I believe that browser in this line, should be possessive (genitive?):

You can disable it from your browser Tools menu.

I also think that this line:

If there are any errors, try disabling Gears, then reload the page and enable it again.

Feels awkward, and I suggest this:

`If there are any errors, try disabling Gears, reloading the page and re-enabling Gears.

Attachments (7)

gears-grammar-fixes.diff (1.1 KB) - added by Speedboxer 16 years ago.
Grammar Fixes for Gears Enabled Box
7176.diff (1.1 KB) - added by ionfish 16 years ago.
gears-grammar-fixes2.diff (1.1 KB) - added by Speedboxer 16 years ago.
Changed the _e() quotes back to single.
gears-grammar-fixes3.diff (1.7 KB) - added by Speedboxer 16 years ago.
Make patch work with latest commits.
gears-grammar-fixes4.diff (1.7 KB) - added by Speedboxer 16 years ago.
Update patch
gears-grammar-fixes5.diff (3.7 KB) - added by Speedboxer 16 years ago.
More changes
gears-grammar-fixes6.diff (3.7 KB) - added by Speedboxer 16 years ago.
Invert the shared/public computer sentence.

Download all attachments as: .zip

Change History (21)

@Speedboxer
16 years ago

Grammar Fixes for Gears Enabled Box

#1 @Speedboxer
16 years ago

  • Keywords has-patch added

@ionfish
16 years ago

#2 @ionfish
16 years ago

Updated the patch with a nicer apostrophe.

@Speedboxer
16 years ago

Changed the _e() quotes back to single.

#3 @Speedboxer
16 years ago

Updated the patch to use single-quotes instead of double-quotes, since the "nicer" apostrophe doesn't need them.

#4 @ionfish
16 years ago

Oops, missed those. Cheers.

#5 @lloydbudd
16 years ago

  • Milestone changed from 2.6 to 2.7
  • Priority changed from normal to low
  • Severity changed from normal to minor

2.6 ship has sailed for non-critical bugs.

@Speedboxer
16 years ago

Make patch work with latest commits.

#6 @Speedboxer
16 years ago

Updated patch to work with the latest Safari-related Gears commits.

#7 @westi
16 years ago

  • Keywords needs-patch added; has-patch removed
  • Owner changed from anonymous to westi
  • Status changed from new to assigned

+1

Patch no longer applies.

Needs updating.

@Speedboxer
16 years ago

Update patch

#8 @Speedboxer
16 years ago

  • Keywords has-patch added; needs-patch removed

Patch has been updated.

#9 @caesarsgrunt
16 years ago

Comma usage is incorrect in the original and in the proposed correction. The first comma should be removed.

Suggestion :
If there are any errors try disabling Gears, reloading the page, and re-enabling Gears.

Or (if you don't like the Oxford comma) :
If there are any errors try disabling Gears, reloading the page and re-enabling Gears.
But this second one is, IMO, not very clear.

@Speedboxer
16 years ago

More changes

#10 @Speedboxer
16 years ago

I fixed that, and made a few more changes. Let me know what you think.

#11 follow-up: @caesarsgrunt
16 years ago

I like most of the changes, but I'm not sure about
However, if this is a public or shared computer, Gears should not be enabled.

I don't really like the commas there - those could be parenthetical commas, setting off an unessential part of the sentence. Perhaps
However, if this is a public or shared computer Gears should not be enabled.
or even
However, Gears should not be enabled if this is a public or shared computer.
would be better.
Or maybe even
Gears should not, however, be enabled if this is a public or shared computer.
Not sure which is best...

#12 in reply to: ↑ 11 @Speedboxer
16 years ago

Replying to caesarsgrunt:

I like most of the changes, but I'm not sure about
However, if this is a public or shared computer, Gears should not be enabled.

I'm not sure, I asked someone I know who's a Writer, and he said it was okay. Although, he also said you could also invert the sentence (your third one). I think I'll go with that. I'll go update the patch now.

@Speedboxer
16 years ago

Invert the shared/public computer sentence.

#13 @caesarsgrunt
16 years ago

Yes, I think that's good.

#14 @westi
16 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [8741]) Improve grammar in Gears Enable Dialog. Fixes #7176 props Speedboxer.

Note: See TracTickets for help on using tickets.