Allow top-level menu page to use a slug, rather than filename

[DD32]

This patch brings the add_menu_page() into align with the rest of the page addition functions, in that it allows the $file to be any string rather than specifically a filename.

It does look a bit hackish in a sense, But i couldnt see any other way to do it.

It certainly needs testing to check it doesnt adversly affect anything else, but it appears fine to me.

I'll also attach a version of the menu-tester plugin which works after this patch (and doesnt work before it)

[DD32]

The change to admin.php could probably be put inside get_plugin_page_hookname somewhere too if need be..

[DD32]

Any chance of this getting in?

By the looks of it, Only the changes to wp-admin/admin.php need to be applied to the current trunk, That is:

wp-admin/admin.php

@@ -45 +45 @@
 
 // Handle plugin admin pages.
 if (isset($plugin_page)) {
-        $page_hook = get_plugin_page_hook($plugin_page, $pagenow);
+        if( ! $page_hook = get_plugin_page_hook($plugin_page, $pagenow) )
+                $page_hook = get_plugin_page_hook($plugin_page, $plugin_page);
 
         if ( $page_hook ) {
                 do_action('load-' . $page_hook);

[DD32]

(Thats lines 60-61 under current trunk, not 48-49)

[ryan]

(In [9147]) Allow top-level menu page to use a slug, rather than filename. Props DD32. fixes #7214