Undefined property in class-IXR.php

[wet]

IXR_Date::$timezone is ​used, but never defined.

[Otto42]

This is already fixed in version 1.7.1 of the library (we have 1.7). Might want to just get the newer one.

​http://griffin.oobleyboo.com/files/xmlrpc/IXR_Library.inc.php.txt

More info here: ​http://griffin.oobleyboo.com/projects/xmlrpc/

[josephscott]

It may be worth getting back in sync with IXR:

​http://code.google.com/p/ixr/

[westi]

Would be good to see a patch to merge the newer IXR into WordPress

[jacobsantos]

It appears that WordPress has the newest version.

[Otto42]

Replying to jacobsantos:

It appears that WordPress has the newest version.

No, it doesn't. There's another version (1.7.1) which fixed that bug and which came out three days later:

​http://griffin.oobleyboo.com/files/xmlrpc/IXR_Library.inc.php.txt

[Otto42]

My bad, wrong link. The one I linked to before was a modified one. This one is the original one, which has the same version number, but which also fixes that bug:

​http://code.google.com/p/ixr/source/browse/trunk/IXR_Library.inc.php

[jacobsantos]

Bringing IXR up to 0.7.1

[jacobsantos]

Patch brings class.ixr.php up to date.

[jacobsantos]

Which in retrospect, is just removing the $this->timezone and changing the name of the library in the class.

[ryan]

(In [8376]) IXR 0.71. Props jacobsantos. fixes #7227

[Nazgul]

This undid the changes for #5666. Was that on purpose?

[ryan]

Looks like that should be upstreamed.

[ryan]

Looks like Joseph already tried: ​http://code.google.com/p/ixr/issues/detail?id=1

[jacobsantos]

When you said get it up to 0.7.1 I thought you meant literally. Sorry.

[ryan]

(In [8377]) Revert accidental bits that snuck in with [8376]. see #7227

[ryan]

(In [8378]) Resurrect 7615. see #7227

[jacobsantos]

Seems fixed to me, now that the bits are fixed.

[wet]

IXR 0.71 won't parse the ISO8610 time zone. This hasn't been beneficial in the past:
​http://trac.wordpress.org/changeset/3279.

IMHO, removing the timezone member variable cures the symptom, not the cause, and this change set would break cross-time zone XML-RPC posting once again.

[jacobsantos]

Damn it. Why use something totally screwed up like this? There are other XML-RPC libraries.

[ryan]

What exactly is the original problem? That parseIso set timezone but parseTimestamp did not?

I'll comment these custom fixes with references to the corresponding tickets once we get everything straightened out.

[ryan]

Patch resurrects timezone and comments all of our modifications.

[anonymized_218323]

Your patch needs to add the timezone property to the beginning of the class or it won't fix the warning.

[ryan]

(In [8403]) Add timezone var to IXR_date. Add timezone back to getIso(). Comment WP specific additions. see #7227

[anonymized_218323]

Isn't this fix now?

[jacobsantos]

Is this fixed yet?

[ryan]

I think so.