The 0th of July

[tellyworth]

It's possible to enter a post date with a zero on the write post page. WP doesn't validate the date, and unless MySQL is running in strict mode the invalid date will get stored in the post_date column.

Steps to reproduce:

1. New Post

2. Edit the timestamp

3. Change the day field to "00"

4. Publish

5. Click the View Post link

Expected: WP should validate the date and change it to something that works.

Actual: the post is published but the permalink is 404 because of a quirk in the way get_permalink() handles the post_date field.

The steps to reproduce assume MySQL is not running in strict mode, I haven't tested that case. Reproduced in trunk, it probably affects all versions.

[tellyworth]

Just to clarify, the post_date field actually stores '2008-07-00' if you do this. It's a MySQL feature, believe it or not.

[ryan]

Quick fix. Year, month, or day <=0 are given the current year, month, or day instead.

[tellyworth]

checkdate() and time validation too

[tellyworth]

My take is in the new patch. It uses checkdate() to cover other invalid dates, and also fixes a minor bug in the time validation (e.g. hours > 48 wasn't handled correctly).

[ryan]

If we use checkdate() we need to put it in a hook so that non-Gregorian calendars can be supported.

[tellyworth]

Ah fair enough, I didn't know we supported them. Take the simpler approach for now then.

[ryan]

Looks like I accidentally checked it in with [8248].