WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 8 months ago

Last modified 8 months ago

#7244 closed enhancement (wontfix)

Disable POP auth when APOP fail

Reported by: lilyfan Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.3
Component: Mail Keywords: has-patch needs-testing reporter-feedback
Focuses: Cc:

Description

If APOP authentication is failed, class-pop3.php tries normal POP auth (USER/PASS).
When a server only accepts APOP authentication, the second process should be fail for sure.
It is nonsence and harmful, because the error message of first process (APOP) is over-written by second try (POP).

To solve the desmiss of APOP fail message, it is neccesary to disable normal POP authentication.
I propose a new class variable $ALLOWLOGIN to decide it.

Additonaly, $ALLOWAPOP is useless because it is no problem to fix it TRUE. (Removing this variable is not included in the patch)

Attachments (2)

pop3.patch (527 bytes) - added by lilyfan 6 years ago.
Patch for wp-includes/class-pop3.php
7244.diff (1.9 KB) - added by Denis-de-Bernardy 5 years ago.
trac-readable version of lilyfan's 7244.patch

Download all attachments as: .zip

Change History (14)

lilyfan6 years ago

Patch for wp-includes/class-pop3.php

comment:1 lilyfan6 years ago

  • Milestone changed from 2.9 to 2.7

comment:2 ryan6 years ago

  • Milestone changed from 2.7 to 2.8

Moving enhancements to 2.8.

comment:3 jacobsantos5 years ago

  • Component changed from General to Mail
  • Owner anonymous deleted

comment:4 Denis-de-Bernardy5 years ago

might be worth pushing this upstream

Denis-de-Bernardy5 years ago

trac-readable version of lilyfan's 7244.patch

comment:6 Denis-de-Bernardy5 years ago

  • Keywords commit added

commit, wontfix?

comment:7 Denis-de-Bernardy5 years ago

  • Keywords needs-testing reporter-feedback added; commit removed

mmm... @lilyfan: why change?

if( (!$count) || ($count == -1) )

comment:8 westi5 years ago

  • Milestone changed from 2.8 to 2.9

Moving to 2.9 as we are in beta now and I don't want to risk changes in this area at this time.

comment:9 Denis-de-Bernardy5 years ago

punting pending reporter feedback

comment:10 Denis-de-Bernardy5 years ago

  • Milestone changed from 2.9 to Future Release

comment:11 avryl8 months ago

  • Resolution set to wontfix
  • Status changed from new to closed

No feedback in over four years.

comment:12 SergeyBiryukov8 months ago

  • Milestone Future Release deleted
Note: See TracTickets for help on using tickets.