WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#7261 closed defect (bug) (fixed)

Press This

Reported by: paulhontz Owned by: noel
Milestone: 2.6 Priority: normal
Severity: major Version:
Component: General Keywords: Press This
Focuses: Cc:

Description

When creating a new post from "Press This", the article does not link back to the original source if you click on the picture tab. If however, you stay on the default tab of text and press the link button, it will work.

These features are very important to tumblogs, or if you link to lots of blogs.

Change History (14)

comment:1 @ryan7 years ago

I see a link back to the source. Could you provide browser information and explicit steps to reproduce?

comment:2 @paulhontz7 years ago

If you don't have any text selected when you click on "Press This", it will automatically put a link in the post with the title (of the site) as the link (example: You are on gmail.com and press the bookmarklet. Your new post would open up with a link that said "Gmail - Inbox (X) - xxxxxx@…".

However, if you have text selected when you press your bookmarklet the whole selection becomes a link. I don't believe this is the intended behavior. To make matters worse, if you then click on the "Photo" tab, the large link converts to plain text and stays like that even if you click back on the "Text" tab

Does this help clarify? I'm using Firefox 3.

however, when I use Safari, or IE7 (the css also appears to be messed up for use with ie7) the editor fails to appear at all. Instead, I see the code (example below)

<a href='http://www.autoblog.com/2008/07/09/g-power-aims-to-rival-m-with-supercharged-z4/'>a natural choice for anyone who wants a high performance BMW, but that hasn't stopped G-Power from offering go-fast parts for Bimmer ow</a>


Also, when I've tried clicking my bookmarklet in IE6, nothing appears. If I click on the link (that you're suppose to add to favorites), it works fine. If I add it to my list, and try and click on it, it fails to open anything.

comment:3 @ryan7 years ago

  • Owner changed from anonymous to noel

comment:4 @ryan7 years ago

(In [8302]) Don't format_to_edit TinyMCE inserts. Don't turn selection into a link. Restore editor contents when switching back to text tab. see #7261 #7220

comment:5 @ryan7 years ago

That fixes up some of the mess.

comment:6 @paulhontz7 years ago

Hey ryan, thanks for your help. I haven't been able to get tiny_mce editor to come up, but I think that might just be something on my end.

Also, would it be possible to have an option to automatically cite your source? Meaning that a link could be placed at the bottom of the post that leads directly back to the webpage you "Press This"ed from?

Thanks again!

comment:7 @paulhontz7 years ago

I think this might have something to do with why the IE 6 bookmarklet doesn't do anything.

http://blog.seagul.co.uk/articles/2007/12/14/bookmarklet-favelet-limits-in-internet-explorer-6-and-7

comment:8 @paulhontz7 years ago

One way to potentially get around this is have separate bookmarklets for *good* browsers, and then one for IE.

By killing off the user agent string to see if it's firefox, you can save quite a few characters, and you should be within the 508 char limit.

comment:9 @paulhontz7 years ago

I can now confirm that if you stay under the 508 character limit that IE6 is limited to, the bookmarklet will appear.

Is there anything else I could try to get the editor and a link?

comment:10 @ryan7 years ago

Is TinyMCE missing from the regular write post page too, or just from Press This?

I'll work on shortening the bookmarklet.

comment:11 @ryan7 years ago

(In [8308]) Reduce size of Press This bookmarklet. see #7261

comment:12 @paulhontz7 years ago

It is only missing in the bookmarklet.

comment:14 @ryan7 years ago

  • Milestone changed from 2.9 to 2.6
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.