WordPress.org

Make WordPress Core

Opened 16 years ago

Closed 16 years ago

Last modified 7 years ago

#73 closed defect (bug) (fixed)

Tags should be stripped from <title /> element

Reported by: rq Owned by: matt
Milestone: Priority: normal
Severity: trivial Version: 1.2
Component: General Keywords:
Focuses: Cc:

Description

If one creates a tagged post name (i.e., with some BOLDness or an ACRONYM in it), that gets reflected in a <title> element. That *should* be stripped anyways.

I don't think it's hard to do, hence, marking it as "trivial".

Attachments (1)

0000073-post.diff (1.1 KB) - added by rq 15 years ago.

Download all attachments as: .zip

Change History (13)

#2 @2fargon
16 years ago

post.diff contains the fix for this "bug".
I also removed a "stripslashes" that didn't seem to be doing anything useful.

#3 @rq
16 years ago

stripslashes may be needed in case of magic_quotes or sth...

#4 @2fargon
16 years ago

Ah! Thanks Matt. I hope the diff is okay. I did a diff using post-old.php(v1.2 file) and post.php(the new one).

#5 @rq
16 years ago

Btw, the link titles still contain markup even w/ this patch... :/

I think, it's probably because a wrong variable is being used there.

#6 @matt
16 years ago

We shouldn't be using stripslashes anymore in the CVS.

#7 @2fargon
16 years ago

I guess it works fine, check http://carthik.net/test for a post without the change and a couple of post with the change.

#8 @rq
16 years ago

Firefox shows the following tooltip on the post "without a change":

Permanent link: < p >testing< /p > without a change.

(with no spaces in "p" tags)

IMO, that's not correct... ;)

edited on: 06-16-04 21:59

edited on: 06-16-04 22:00

edited on: 06-16-04 22:01

#9 @2fargon
16 years ago

I just added the without a change to show how the tags are there without the changes I made. The next two posts are ones made with the changed post.php file.

#10 @matt
16 years ago

  • Owner changed from anonymous to matt
  • Resolution changed from 10 to 20
  • Status changed from new to closed

Inside of wp_title() we strip_tags.

@rq
15 years ago

This ticket was mentioned in IRC in #wordpress-dev by kadamwhite. View the logs.


7 years ago

Note: See TracTickets for help on using tickets.