#7337 closed defect (bug) (fixed)
Consistently use $wp_rewrite->index instead of hardcoding "index.php"
| Reported by: | markjaquith | Owned by: | ryan |
|---|---|---|---|
| Priority: | low | Milestone: | 3.6 |
| Component: | Permalinks | Version: | 2.6 |
| Severity: | minor | Keywords: | has-patch |
| Cc: | Focuses: |
Description
A few place in our URL generation and canonicalization code use hardcoded "index.php" instead of using $wp_rewrite->index
This prevents people from using custom PATHINFO permalinks.
Attachments (2)
Change History (17)
#7
in reply to: ↑ 5
@
15 years ago
- Keywords close removed
Replying to solarissmoke:
Is this still an issue?
Yep, in some files:
wp-admin/options-permalink.phpwp-includes/canonical.phpwp-includes/link-template.phpwp-includes/nav-menu-template.php(maybe unrelated though)wp-includes/rewrite.php
#11
@
13 years ago
- Resolution fixed
- Status closed → reopened
This breaks _wp_menu_item_classes_by_context() in nav-menu-template.php.
Notice: Undefined variable: wp_rewrite in wp-includes/nav-menu-template.php on line 370
Notice: Trying to get property of non-object in wp-includes/nav-menu-template.php on line 370
Need $wp_rewrite to be global for it to work.
Not sure if it breaks other places, but this is the only one I've seen.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Is this still an issue?