WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#7342 closed defect (bug) (fixed)

Press This sideloader fixes and wp_handle_upload fixes

Reported by: noel Owned by: azaozz
Milestone: 2.6.1 Priority: normal
Severity: normal Version:
Component: General Keywords:
Focuses: Cc:

Description

Press This was not sideloading images as it was intended. This was actually a good feature to leave out as I found a bug in the wp_upload_dir function that would allow the $url to be == to the $dir and output something ugly like:

http://bookmarklet.site//Users/noel/Sites/bookmarklet.site/public/wp-content/uploads/2008/07/filename.jpg

Fixes are short and sweet.

Attachments (1)

press-this_7-17.patch (2.0 KB) - added by noel 6 years ago.
Press This and patches for wp_upload_dir()

Download all attachments as: .zip

Change History (3)

noel6 years ago

Press This and patches for wp_upload_dir()

comment:1 ryan6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [8369]) Image sideload and wp_upload_dir() fixes from noel. fixes #7342 for trunk

comment:2 ryan6 years ago

(In [8370]) Image sideload and wp_upload_dir() fixes from noel. fixes #7342 for 2.6

Note: See TracTickets for help on using tickets.