WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#7366 closed defect (bug) (fixed)

Incorrect message displayed on editing link categories

Reported by: scohoust Owned by:
Milestone: 2.6.1 Priority: normal
Severity: normal Version: 2.6
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

When updating a link category, if the update causes an error (duplicate slug, for example), the message displayed is still "Category updated" even though it hasn't.

Stems from #4809 where link_category.php isn't expecting WP_Error returned.

Attachments (1)

7366.diff (611 bytes) - added by scohoust 7 years ago.
Checks for WP_Error and displays accordingly

Download all attachments as: .zip

Change History (5)

@scohoust7 years ago

Checks for WP_Error and displays accordingly

comment:1 @scohoust7 years ago

  • Keywords has-patch added

Not ideal, as the user has no idea why the update didn't work, but the patch keeps it consistent with tags and post categories.

comment:2 @ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [8391]) Check for WP_Error return from wp_update_term(). Props scohoust. fixes #7366 for trunk

comment:3 @ryan7 years ago

  • Milestone changed from 2.7 to 2.6.1

comment:4 @ryan7 years ago

(In [8392]) Check for WP_Error return from wp_update_term(). Props scohoust. fixes #7366 for 2.6

Note: See TracTickets for help on using tickets.