WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#7367 closed defect (bug) (fixed)

Redundant logic in script and style queuing classes

Reported by: sambauers Owned by:
Milestone: Priority: low
Severity: minor Version: 2.6
Component: Optimization Keywords: dev-feedback
Focuses: Cc:

Description

I am pretty sure that the changes here:

http://trac.wordpress.org/changeset/8301/trunk/wp-includes/class.wp-scripts.php

And here:

http://trac.wordpress.org/changeset/8301/trunk/wp-includes/class.wp-styles.php

Introduce redundant code.

WP_CONTENT_URL should always be a fully qualified URL so it will match the first condition and never reach the second.

I think these should be reverted, but maybe I'm just not reading it right.

Change History (8)

comment:1 santosj6 years ago

It appears that if the $src is relative, it will try to add on the WP_CONTENT_URL to the $src to ensure that the relative link is pointing to the right location.

I don't believe it is about WP_CONTENT_URL and about the location of the CSS or Script file.

comment:2 santosj6 years ago

  • Milestone changed from 2.6.1 to 2.7

Moving to 2.7, since it will have to be added to trunk first.

comment:3 sambauers6 years ago

  • Milestone changed from 2.7 to 2.8

This is not critical for 2.7

comment:4 jacobsantos5 years ago

  • Component changed from General to Optimization

comment:5 jacobsantos5 years ago

  • Milestone 2.8 deleted
  • Resolution set to invalid
  • Status changed from new to closed

The change is intentional.

comment:6 sambauers5 years ago

  • Keywords BackPress added
  • Milestone set to 2.8
  • Resolution invalid deleted
  • Status changed from closed to reopened
  • Summary changed from Maybe redundant logic in script and style queuing classes to Redundant logic in script and style queuing classes

If the logic is followed in all cases except misconfiguration this additional part of the condition is definately redundant. It also diverges from the original abstract BackPress class by imtroducing a WordPress specific constant.

comment:7 Denis-de-Bernardy5 years ago

  • Keywords dev-feedback added; BackPress removed

comment:8 Denis-de-Bernardy5 years ago

  • Milestone 2.8 deleted
  • Resolution set to fixed
  • Status changed from reopened to closed

ticket is no longer valid in trunk.

Note: See TracTickets for help on using tickets.