Display multiple tag titles on tag unions and intersections

[ionfish]

Currently, tag unions and intersections only display the title of the first tag in the query, rather than all of them. This patch adds a new template function, multiple_tag_titles, which displays one or more tag titles for tag intersections and unions, adding a final 'and' or 'or' conjunction where appropriate.

Having written this patch, I'm starting to think it's the wrong approach: multiple taxonomy titles for taxonomy unions and intersections would be preferable.

[ryan]

Moving enhancements to 2.8.

[ionfish]

Patch is stale; attaching a new one applied against trunk.

[ionfish]

Just tested the patch against latest trunk, seems to still apply ok.

[Denis-de-Bernardy]

_implode_nicely() would work with languages that read from right to left, or?

oh, and @since 2.7 should be @since 2.8 :-)

[ionfish]

Fixed the @since, cheers.

_implode_nicely() should work fine with RTL languages as long as they have list syntax that's similar enough to English (although guidance from someone with more experience in that area would be appreciated). One thing that strikes me now is that it probably shouldn't add spaces automatically, as it prevents one from just using a final comma rather than a connective word.

[Denis-de-Bernardy]

for the commas, see #7897

[ionfish]

The commas are run through () in the latest patch. I'm also wondering whether multiple_tag_titles() should be renamed to just tag_titles().

[Denis-de-Bernardy]

might be. also of potential issue is the filter's name. it might be that some plugins relied on its old (single) version, if any.

[ionfish]

In that case, would it be worth passing the results through both filters and deprecating single_tag_title()?

[Denis-de-Bernardy]

this is just a guess: for backwards compatibility sake, core devs might think it's preferable to change the behavior of the new function (and pass all of the tags through the single_tag_title filter (or whatever it's called). and if they think like that I'd actually agree with them.

[ryan]

This adds extra queries per tag, which is why we didn't add this from the beginning. Reducing to one query would be nice. In query.php where we do the single tag query we could call get_terms() with either 'include' or 'slugin' (which doesn't exist yet).

Can we add this to single_tag_title()so themes don't have to update templates?

The i18n on this is ugly, but I don't know if there's a good way to avoid concatenating strings.

$glue = __(', '), $conjuction = __(' and ')

You can't use function return as a default. We usually default to false or null and then assign the default string if false inside the function.

[Denis-de-Bernardy]

Replying to ryan:

This adds extra queries per tag, which is why we didn't add this from the beginning. Reducing to one query would be nice.

you mean on the get_terms() and get_term_by() calls, right? if so, there's room to bulk grab tags in order to cache the result, ya.

[Denis-de-Bernardy]

moving to future from lack of refreshed patch

[ionfish]

Since it seems like a new patch would be slightly involved, I'll run one up for 2.9.

[scribu]

Related: #12891

[chriscct7]

Closing as maybelater. Complete lack of interest on the feature on the ticket over the last 6 years. Feel free to reopen when more interest re-emerges (particularly if there's a patch)