When looking for rewrite rules matches, change preg_match start/end character from ! to % or #

[aesqe]

In classes.php, around line 100 (lines 104 and 105 in WP 2.6, class WP) when trying to find rewrite rule matches, ! (exclamation mark) is used as start/end for regexp in the preg_match function. Should be changed to % or # to enable use of, for example, (?!) in rules.

[jacobsantos]

Patch is based off of r10258

[jacobsantos]

Has patch, sending to 2.8.

[DD32]

preg_quote() is not the answer, that escapes all content within it, so as to render any rules useless.

would anyone have a need to use # in a rewrite rule?

[mrmist]

Replying to DD32:

would anyone have a need to use # in a rewrite rule?

Only if you were doing non-escaped redirection on an anchor. I guess it would be pretty rare.

[DD32]

Only if you were doing non-escaped redirection on an anchor. I guess it would be pretty rare.

Does the Anchor even get sent -to- the server? I dont think it does?

Eitherway, It needs to use something as a delim. I would think # wouldnt be used within a URL (assuming its not sent to the server, and i'm pretty sure it isnt) in order to prevent confusing browsers, else it'd have to be escaped.. and that would just be plain ugly..

[jacobsantos]

Patch based off of 10569 that uses '#' instead of '!'

[westi]

(In [10573]) Use # as the delimiter for preg_match in rewrite rules to allow them to contain !. Fixes #7486 props jacobsantos.