WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 4 years ago

#7493 closed enhancement (fixed)

_deprecated() version numbers.

Reported by: docwhat Owned by: westi
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Inline Docs Keywords: has-patch early
Focuses: Cc:

Description

This is a patch to change the "deprecated since 0.0" messages to their correct number.

Attachments (3)

deprecated.php.patch (17.3 KB) - added by docwhat 6 years ago.
7493-deprecated-docs.diff (36.0 KB) - added by nacin 4 years ago.
7493-deprecated-docs.2.diff (41.9 KB) - added by nacin 4 years ago.
Updated patch also removes $deprecated args that don't affect argument order -- see #11386. Also, some whitespace improvements for _deprecated_function() calls.

Download all attachments as: .zip

Change History (12)

docwhat6 years ago

comment:1 follow-up: santosj6 years ago

You're using Ozh Version list, but I believe the deprecated version numbers are when the function was deprecated, not when the function was added.

comment:2 in reply to: ↑ 1 westi6 years ago

  • Keywords needs-patch added; has-patch removed
  • Owner changed from anonymous to westi
  • Status changed from new to assigned

Replying to santosj:

You're using Ozh Version list, but I believe the deprecated version numbers are when the function was deprecated, not when the function was added.

That is correct.

comment:3 jacobsantos6 years ago

  • Milestone changed from 2.7 to 2.8

comment:4 jacobsantos5 years ago

  • Type changed from defect (bug) to enhancement

comment:5 Denis-de-Bernardy5 years ago

  • Milestone changed from 2.8 to Future Release

comment:6 Denis-de-Bernardy5 years ago

  • Component changed from General to Inline Docs

comment:7 nacin4 years ago

  • Keywords has-patch early added; needs-patch removed
  • Milestone changed from Future Release to 3.0

To align with #10920.

Tons of new phpdoc here.

nacin4 years ago

comment:8 nacin4 years ago

FWIW, every version number for '0.0' values was traced back through changesets, revisions and tickets. Not guaranteeing 100% accuracy but it should be.

On occasion, @since and @deprecated are the same version. The function was added early in a dev cycle and removed later on in the same cycle.

#10920 was incorporated into this patch.

nacin4 years ago

Updated patch also removes $deprecated args that don't affect argument order -- see #11386. Also, some whitespace improvements for _deprecated_function() calls.

comment:9 ryan4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [12526]) Set the version of WP a function was deprecated in for all deprecated functions. Props nacin, docwhat. fixes #7493

Note: See TracTickets for help on using tickets.