WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#7520 closed enhancement (wontfix)

Image default options for size, alignment and link type

Reported by: tellyworth Owned by: azaozz
Milestone: Priority: high
Severity: normal Version: 2.7
Component: General Keywords: needs-patch dev-feedback
Focuses: Cc:

Description

This adds options to Settings/Misc that let you specify default values for the image size, alignment and link type (post/file/none). The, uh, default defaults are as per 2.6 behaviour.

Further work is needed to apply the defaults to the upload form, this currently works only in the media library tab.

Attachments (2)

image-default-options-r8645.patch (9.7 KB) - added by tellyworth 7 years ago.
image-default-options-r8652-2.patch (11.7 KB) - added by tellyworth 7 years ago.
improved patch works with external images also

Download all attachments as: .zip

Change History (15)

comment:1 @tellyworth7 years ago

  • Keywords has-patch added

Guh. No writing patch descriptions before bedtime. This *does* work for the upload form, and the gallery tab too. The 'From URL' form for inserting an external image is the only part that doesn't respect the options. That needs to be added but I'd like to see the patch go in as-is for testing and feedback first.

@tellyworth7 years ago

improved patch works with external images also

comment:2 @ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [8653]) Image default options for size, alignment and link type. Props tellyworth. fixes #7520

comment:3 @matt7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

This is option bloat - we should just remember and default to whatever you used last, just like with Visual / HTML.

comment:4 @lloydbudd7 years ago

  • Keywords needs-patch added; has-patch removed
  • Version set to 2.7

comment:5 @tellyworth7 years ago

Fair enough. Removing the hard-coded defaults isn't a bad thing to do. I'd suggest keeping that part, move them to hidden options, and drop the UI. That way if someone wants to they can write a plugin that provides a UI for setting them -- or overrides them in some other way with filters.

comment:6 @ryan7 years ago

#6655 related

comment:7 @ryan7 years ago

  • Owner changed from anonymous to azaozz
  • Priority changed from normal to high
  • Status changed from reopened to new

comment:8 @azaozz7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [9654]) Keep state for image size, alignment and url in the uploader and for categories view on the write page, fixes #7520

comment:9 @azaozz7 years ago

(In [9655]) Refresh js, see #7520

comment:10 @randyhoyt7 years ago

  • Milestone changed from 2.7 to 2.7.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

The new hidden options aren't working correctly. If you look at the HTML, it looks like the proper radio buttons have a value of checked="checked", but something else is overriding those selections. Is this a bug, or was tellyworth's suggestion to hide these options rejected?

If it was rejected, I want to reopen this bug and argue in favor or tellyworth's suggestion. I disagree that having these default options is "feature bloat". Every site I have worked on has a most-used behavior (thumbnails links to the post URL, for example, or medium images with no links). Every now and then, the user will need to deviate from this (adding a large image with a link to an external web site, for example). A week later, when the user logs in, they expect it to work the way it usually does. They won't remember whether the last time they uploaded an image, they used the most-used behavior or something different. The users expectations are not shaped by what they did last week, and I would argue that the applications behavior shouldn't either.

(I would also make this same argument regarding the Visual Editor / HTML Editor. Every single time I switch over to the HTML editor, save something, and navigate to a different post, it is a jarring experience that goes against my expectations when the HTML editor loads. But since there are only two options and most of my clients don't use the HTML editor, I don't think it's a big deal.)

comment:11 @FFEMTcJ7 years ago

  • Milestone changed from 2.7.2 to 2.8

comment:12 @Denis-de-Bernardy6 years ago

  • Keywords dev-feedback added

see also #9600. suggesting wontfix for this one.

comment:13 @ryan6 years ago

  • Milestone 2.8 deleted
  • Resolution set to wontfix
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.