Missing closing php bracket in wp-admin/js/revisions-js.php

[webrocker]

Not sure if this is intentional or not, but in the
revisions-js.php there is no closing/ending "?>" bracket in the last line.

[scohoust]

Adds in php closing tag

[santosj]

There are several files already where the lack of a closing tag is intentional.

[webrocker]

I thought as much, but under what circumstances does this (leaving out the closing tag) make sense? this is the first time I come across this issue. I always thought a (inlcude) or whatever-php-file needs to be proper closed...? thanks for enlightment,
Tom

[Viper007Bond]

IMO it should be in every single file except maybe wp-config.php. I think this ticket is valid.

[jacobsantos]

BackPress doesn't have the closing PHP tag.

@Tom The closing PHP tag is optional, as long as there isn't any non-PHP code after.

[Viper007Bond]

Replying to jacobsantos:

BackPress doesn't have the closing PHP tag.

Then it should. I believe we all had this discussion before and it was decided it was best to have one. Besides being "proper", it's a helpful way for users to make sure a file was completely uploaded. There's also zero reason whatsoever to not have one.

[Viper007Bond]

Replying to Viper007Bond:

There's also zero reason whatsoever to not have one.

(I'm of course excluding user edited files.)

[webrocker]

Replying to jacobsantos:

@Tom The closing PHP tag is optional, as long as there isn't any non-PHP code after.

Thanks for the info, I didn't know that.

Replying to Viper007Bond:

it's a helpful way for users to make sure a file was completely uploaded

I second that, still. :-)