WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#7539 closed enhancement (fixed)

get_terms doesnt use custom orderby

Reported by: gimler Owned by: ryan
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.7
Component: Taxonomy Keywords: has-patch commit
Focuses: Cc:

Description

i wan't to use it for sort with my costum column

Attachments (2)

get_terms_order.diff (383 bytes) - added by gimler 7 years ago.
7539.diff (877 bytes) - added by DD32 6 years ago.

Download all attachments as: .zip

Change History (7)

@gimler7 years ago

comment:1 @DD326 years ago

  • Keywords has-patch dev-feedback added

comment:2 @jacobsantos6 years ago

  • Summary changed from [PATCH] get_terms not use costum orderby to [PATCH] get_terms not use custom orderby

comment:3 @DD326 years ago

  • Component changed from General to Taxonomy
  • Milestone changed from 2.7 to 2.8
  • Owner changed from anonymous to ryan
  • Summary changed from [PATCH] get_terms not use custom orderby to get_terms doesnt use custom orderby
  • Type changed from defect to enhancement
  • Version set to 2.7

The attached patch is useless, Well, In the sense that $orderby will *allways* be set.

I've attached another patch which might be better suited.

I also feel this is an enhancement as it adds functionality, not corrects a bug as its not a defined use case, Its not expected that you would have a reason to add a new column.

@DD326 years ago

comment:4 @Denis-de-Bernardy6 years ago

  • Keywords commit added; dev-feedback removed

+1

comment:5 @westi6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11250]) Allow for custom ordering in get_terms(). Fixes #7539 props DD32.

Note: See TracTickets for help on using tickets.