WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#7613 closed defect (bug) (fixed)

Impossible to clear list of recently active plugins

Reported by: caesarsgrunt Owned by:
Milestone: 2.7 Priority: high
Severity: normal Version: 2.7
Component: Administration Keywords: has-patch commit
Focuses: Cc:

Description

It is no longer possible to clear the list of recently active plugins, in WP2.7-haemorrhage (trunk). This is caused by the new 'Actions' dropdown (which I don't like, BTW, though I understand the reasons for it) overriding the previously-set $action variable.

Patch attached.

Attachments (2)

7613.diff (374 bytes) - added by caesarsgrunt 7 years ago.
Patch for issue described.
7613.2.diff (404 bytes) - added by caesarsgrunt 7 years ago.
Patch which checks isset and !empty to avoid notices.

Download all attachments as: .zip

Change History (8)

@caesarsgrunt7 years ago

Patch for issue described.

comment:1 @caesarsgrunt7 years ago

This won't work if the value of $_REQUESTaction? is ever 0, '0', or an array - but I don't think it ever is.

comment:2 @caesarsgrunt7 years ago

Ooops. I hate automatic linking.
That should have been $_REQUEST['action'].

comment:3 @santosj7 years ago

  • Keywords needs-patch added; has-patch removed

This will cause a notice if $_REQUEST['action'] doesn't exist. The isset check is there to ensure that the key index exists before checking. The correct patch will add the !empty() check after the isset() check.

@caesarsgrunt7 years ago

Patch which checks isset and !empty to avoid notices.

comment:4 @caesarsgrunt7 years ago

  • Keywords has-patch added; needs-patch removed

Yes, of course. Sorry about that. This should be OK, I think.

comment:5 @santosj7 years ago

  • Keywords commit added

comment:6 @westi7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [8755]) Make it possible to clear the recently active plugins list. Fixes #7613 props caesarsgrunt.

Note: See TracTickets for help on using tickets.