Merge all atom parsers

[westi]

Currently we have two Atom Parsers. One for the Blogger Importer and one for our APP implementation.

We need to only have one!

[westi]

First pass. Rip it out of the blogger importer and use atomlib, add the extra tag to atomlib

[westi]

That is very rough and needs some testing.

[westi]

TODOs:

• Change AtomLib so that parse can be passed the xml.
• Change the Blogger importer to use a single AtomParser for the whole feed and iterate over the parsed Entries.

[Denis-de-Bernardy]

just for reference, there was some discussion about using simplepie for this one in IRC

[Denis-de-Bernardy]

see #10147

[Denis-de-Bernardy]

see also #7644

[Denis-de-Bernardy]

see also #9524

[westi]

Related tickets: #4555 (MT and TypePad) , #7644 (MT), #7543 (TypePad)

[rmccue]

Taking this for ​Google Code-In.

I think I'll take the SimplePie route for this, as I have the most experience with it, and I think it's a natural match.

[rmccue]

First pass at the APP create_post() conversion

[rmccue]

One thing I don't like about this patch is the hack to get it to work with SimplePie. SP expects a normal, Atom syndication feed (with the top-level element being feed), while this is AtomPub. The str_replace hack should work, but there's probably a better way to do it.

[rmccue]

All of AtomParser converted to SimplePie in wp-app.php

[rmccue]

wp-app.php should be done now

[westi]

This is looking good.

Did you manage to get APE working enough to test this out?

Well done :-)

[rmccue]

Using the override, I was able to, however, it appears Ape doesn't use the credentials you pass to it. I'll see about fixing this bug in Ape (my Ruby is rather poor), but I doubt they accept patches often.

I'd still like to move this into the unit testing and rewrite the tests in PHP (which should be easy), but that's out-of-scope for this task/bug.

As for the importers, these have now been spun off into their respective plugins, so I'll be taking a look at these next.

[rmccue]

Regarding Ape results, the warnings generated are:

• Summary changes - WP adds the "Read more" link. This is normal.
• Content changes - Content is trimmed. I believe this is also normal behaviour.
• "Server discarded foreign markup" - Not sure on this one.
• Slug doesn't match - Normal for non-rewritten permalinks
• "Published entry retains dangerous hyperlink: 'javascript:evil'." - kses problem?
• "Pictures apparently not in collection" - Did not touch this code, so should be fine.

[rmccue]

Blogger Importer conversion

[rmccue]

This patch converts the Blogger Importer to use SimplePie, and I believe it completes this ticket. Still existing, but out-of-scope for this task are #4555, #7644 and #7543.

One part of this that will need to be tested is the timestamp handling. I'm not entirely sure I nailed that down fully in this importer, and I may have missed something (especially if the timezones from the imported blog and the WP blog don't match).

Due to the impracticality of writing unit tests for these (as doing so would require access to Blogger's servers), the only testing that can be done is manual testing. Unit testing may be possible for the Atom API, and I'll investigate that in the next day until my deadline expires. If I haven't completed that, I'll file a new issue for it. :)

[rmccue]

Separate WP_SimplePieAtomPub_Item into class-feed.php

[westi]

Great work!

[westi]

There is great work on this ticket but it is going to need a fair chunk of testing so I don't think we should try and merge it in the 3.2 cycle - if I get time I will look at merging the Blogger importer changes into the plugin though

[kurtpayne]

Refreshed for 3.4

[kurtpayne]

Refreshed rmccue's patched for 3.4 and ran Gorilla against it. Looks like everything passed.

C:\Gorilla\bin>gorilla --user=admin --pass=******** --uri=http://127.0.0.1/wordpress-trunk/wp-app.php ServiceDocumentTest
Gorilla is beginning testing on http://127.0.0.1/wordpress-trunk/wp-app.php...


testServiceDocumentExists with data set #0
------------------------------------------
[info] Service document found
[result] success

testCollectionsExist with data set #0
-------------------------------------
[info] Collections found:
    Test Blog Posts accepts application/atom+xml;type=entry
    Test Blog Media accepts image/*, audio/*, video/*
[result] success

testHasJPEGCollection with data set #0
--------------------------------------
[info] JPEG collections found:
    Test Blog Media
[result] success

C:\Gorilla\bin>gorilla --user=admin --pass=******** --uri=http://127.0.0.1/wordpress-trunk/wp-app.php EntryPostsTest
Gorilla is beginning testing on http://127.0.0.1/wordpress-trunk/wp-app.php...


testListPosts
-------------
[info] Post collections found:
    Test Blog Posts
[info] Using Test Blog Posts at http://127.0.0.1/wordpress-trunk/wp-app.php/posts
[info] Checking current
[result] success

testSparsePost
--------------
[info] Testing basics
[info] Posting of new entry reported success, location: http://127.0.0.1/wordpress-trunk/wp-app.php/post/1802
[result] success

testPostFromTemplate with data set #0
-------------------------------------
[info] Creating from Gorilla/lib/tests/data/posts/example-1.xml
[info] Posting of new entry reported success, location: http://127.0.0.1/wordpress-trunk/wp-app.php/post/1804
[info] Examining the new entry as returned in the POST response
[info] Slug was used in server-generated URI
[info] Checking at the new location
[result] success

[Workshopshed]

So did WP_SimplePieAtomPub_Item make it into the latest 3.4 builds as I don't see it.

[Otto42]

Blogger importer now uses SimplePie as of 0.5.

[chriscct7]

#7644 was marked as a duplicate.