Count in wp_sprintf_l() is used, but not defined.

[jacobsantos]

The function checks for the $i variable, which I assume is supposed to be from the count, but is never defined. The condition that uses that variable will always be false all cases. Patch defines the variable, which is hopefully what the developer had in mind.

The note about being greater than 2 items is not checked for and is another bug, I suspect. I suppose the intention is to have the remaining item appended after and break out of the loop, however the only check is a boolean, which is not suffice of a check to ensure this.

[jacobsantos]

defines variable based off of r8781.

[ryan]

Don't count in loop

[ryan]

Patch pulls count out of the loop. That function is rather odd.

[jacobsantos]

Your patch works for me.

[jacobsantos]

Except that it could be that the $i-- belongs at the end. I'll say, an offset mistake is better than a complete malfunction, since it would be an easy change to fix later.

[westi]

(In [9189]) Notice fix and don't count inside a loop. Fixes #7653 props ryan.