WordPress.org

Make WordPress Core

Opened 6 years ago

Last modified 3 months ago

#7665 assigned enhancement

Add jQuery UI's datepicker() where applicable

Reported by: Viper007Bond Owned by: chsxf
Milestone: Future Release Priority: lowest
Severity: normal Version: 2.7
Component: Editor Keywords: has-patch needs-testing
Focuses: ui Cc:

Description (last modified by aaroncampbell)

Obviously it'll need some skinning, but it's handy dandy:

http://jqueryui.com/demos/datepicker/

It'd be slick to have that for choosing dates (for example publish dates). We should still allow manual entry though.

Attachments (5)

patch-jquery-date-and-time-picker.diff (32.0 KB) - added by chsxf 3 years ago.
Unified diff of the modified files
patch-jquery-date-and-time-picker-new-files.tar.gz (36.4 KB) - added by chsxf 3 years ago.
New files (JavaScript and CSS files)
patch-jquery-date-and-time-picker2.diff (29.6 KB) - added by chsxf 3 years ago.
New unified diff of the modified files
patch-jquery-date-and-time-picker-new-files2.tag.gz (50.7 KB) - added by chsxf 3 years ago.
New package of the new files (JavaScript and CSS files)
patch-jquery-date-and-time-picker3.diff (29.6 KB) - added by chsxf 3 years ago.
Synced-with-lastest-trunk-revision unified diff of the modified files

Download all attachments as: .zip

Change History (46)

comment:1 ryan6 years ago

Datepicker linked to dropdowns might be nice. We'd need to massage its i18n to use our gettext.

comment:2 caesarsgrunt6 years ago

+1. I'd really like a datepicker.
But themed; the example one on jquery.com is uuuglyyy...

comment:3 ShaneF6 years ago

+1, as well.

comment:4 ryan6 years ago

  • Milestone changed from 2.7 to 2.8

comment:5 ydekproductions5 years ago

  • Version changed from 2.7 to 2.8

Hey guys, I know this is a bit early, but I have a pretty good understanding of this, and I'd like to tackle this if nobody else is. :)

Got any ideas on how the skin should look?

comment:6 jacobsantos5 years ago

  • Milestone changed from 2.8 to 2.9

No patch.

comment:7 FFEMTcJ5 years ago

  • Milestone changed from 2.9 to Future Release

comment:8 Denis-de-Bernardy5 years ago

  • Component changed from Administration to JavaScript
  • Milestone changed from Future Release to 2.9
  • Owner changed from anonymous to azaozz

comment:9 Denis-de-Bernardy5 years ago

  • Component changed from JavaScript to Editor
  • Owner azaozz deleted

comment:10 Denis-de-Bernardy5 years ago

  • Milestone changed from 2.9 to Future Release

punting this back pending patch

comment:11 johnbillion3 years ago

  • Cc johnbillion@… added

comment:12 dahamsta3 years ago

+1 for a proper date picker, scheduling is incredibly awkward at the moment.

Please merge with #11942

Last edited 3 years ago by scribu (previous) (diff)

comment:13 scribu3 years ago

  • Cc scribu added

comment:14 goldenapples3 years ago

  • Cc goldenapples added

comment:15 aaroncampbell3 years ago

  • Cc aaroncampbell added
  • Description modified (diff)
  • Version changed from 2.8 to 2.7

Just updating the link in the description

comment:16 chsxf3 years ago

  • Cc christophe@… added

comment:17 chsxf3 years ago

I'm working on a patch for this.
It should be available by the end of the week, maybe earlier.

comment:18 chsxf3 years ago

  • Owner set to chsxf
  • Status changed from new to assigned

chsxf3 years ago

Unified diff of the modified files

chsxf3 years ago

New files (JavaScript and CSS files)

comment:19 chsxf3 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

comment:20 follow-up: scribu3 years ago

It would be nice if you could find a way to avoid using date_parse_from_format().

Also, commonL10n.datePicker_month01 etc. is really ugly. Related: #11520

comment:21 in reply to: ↑ 20 chsxf3 years ago

Replying to scribu:

It would be nice if you could find a way to avoid using date_parse_from_format().

Also, commonL10n.datePicker_month01 etc. is really ugly. Related: #11520

I can search a way to avoid using date_parse_from_format() but what is the problem with this function ? Does the problem come from my placeholder implementation of the function ?

Concerning the second point, I may use the official translations provided by jQuery for the date picker but I still need to provide at least translations for the time picker and the firstDay setting for the date picker. Is this OK if I leave those ones inside commonL10n or not ?

chsxf3 years ago

New unified diff of the modified files

comment:22 chsxf3 years ago

New attachments include some modifications for the date picker translations by supporting official jQuery translations.

For the PHP side, I still use date_parse_from_format() as I don't find another way to handle dates correctly yet.

Note : replaced tar.gz attachment because a file was missing. Sorry for the typo in the file suffix but it is not possible for me to rename the attachment.

Last edited 3 years ago by chsxf (previous) (diff)

chsxf3 years ago

New package of the new files (JavaScript and CSS files)

comment:23 scribu3 years ago

Closed #18659 as dup.

comment:24 sirzooro3 years ago

  • Cc sirzooro added

#17952 / [18757] added jQuery datepicker to WP Core. Now is probably too late to get this ticket resolved in WP3.3, but it is a good candidate for WP3.4 Please make sure that patch is up to date.

chsxf3 years ago

Synced-with-lastest-trunk-revision unified diff of the modified files

comment:25 chsxf3 years ago

Latest attachment contains my patch synced against today's latest trunk (WP 3.3 development version - r18813)

comment:26 ciantic2 years ago

  • Cc ciantic@… added

Is this patch missing something, or why this is not commited to trunk?

Patch seems awesome and not committing or giving advice how to improve it (so it gets commited) is just rude for the patch-maker. Wasting ones time on upgrading patch against trunk again and again!

Everybody needs this patch (or at least me!)

comment:27 scribu2 years ago

Is this patch missing something, or why this is not commited to trunk?

http://wpdevel.wordpress.com/version-3-3-project-schedule/

Everybody needs this patch (or at least me!)

lol

comment:28 WraithKenny2 years ago

related #18909

I've noticed with the current version of jQuery, and the current version of jQuery UI that the datepicker's events have issues (create, onChangeMonthYear, onSelect don't fire, beforeShowDay gives errors, onClose and beforeShow did work) At least with my tests.

Also, datepicker doesn't support "Theme CSS Scope" (for multiple themes per page).

Last edited 2 years ago by WraithKenny (previous) (diff)

comment:29 follow-up: WraithKenny2 years ago

Please also consider an html5 input[type="date"] with feature detection to fail back onto jQuery UI. Opera is the only decent native datepicker though.

comment:30 follow-up: iandunn2 years ago

  • Cc ian_dunn@… added

+1 for this; I'd really like to be able to use datepicker() in plugins/themes. I don't see why the entire jQueryUI library wasn't added to core. Just because the WP core doesn't use it doesn't mean that plugins/themes won't, and it's counter-intuitive to have only parts of a library available. If you say that jQueryUI is bundled w/ WP then ALL of it should be bundled, not just certain parts.

I'm not suggesting that it be enqueued by default, of course, just that it should be available so that plugins/themes can enqueue it when needed.

comment:31 in reply to: ↑ 30 ; follow-ups: scribu2 years ago

Replying to iandunn:

I don't see why the entire jQueryUI library wasn't added to core.

It was, in WP 3.3.

comment:32 in reply to: ↑ 31 iandunn2 years ago

Replying to scribu:

Replying to iandunn:

I don't see why the entire jQueryUI library wasn't added to core.

It was, in WP 3.3.

Ah, sweet :) I must have missed that.

comment:33 in reply to: ↑ 31 WraithKenny2 years ago

Replying to scribu:

Replying to iandunn:

I don't see why the entire jQueryUI library wasn't added to core.

It was, in WP 3.3.

I think he meant the css themes...

comment:34 scribu2 years ago

If he did, there's a ticket for that already: #18909

comment:35 jtsternberg18 months ago

  • Cc justin@… added

+Let's do it!

comment:36 ericlewis18 months ago

  • Cc eric.andrew.lewis@… added

comment:37 sillybean14 months ago

  • Cc steph@… added

comment:38 in reply to: ↑ 29 thisislawatts11 months ago

Replying to WraithKenny:

Please also consider an html5 input[type="date"] with feature detection to fail back onto jQuery UI. Opera is the only decent native datepicker though.

This is also something shipping in Chrome since August 2012 and a quick 'looks at the iPhone' check, shows it is well implemented in iOS 5.x, so if this is added I think applying jQuery UI conditionally has to be the best way right?

Last edited 11 months ago by thisislawatts (previous) (diff)

comment:39 Apiweb3 months ago

  • Severity changed from minor to normal
  • Version 2.7 deleted

Also I think they should always be considered the html5 input [type = "date"] as default and use jQuery as failback.

comment:40 markoheijnen3 months ago

  • Version set to 2.7

My problem I have with html5 input fields is that they aren't consistent in all browsers. So I'm curious how easy it would be to make that so.

comment:41 jeremyfelt3 months ago

  • Focuses ui added
Note: See TracTickets for help on using tickets.