WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#7760 closed enhancement (invalid)

Files size reduce - replace "4xSpace" with "Tab"

Reported by: Simek Owned by:
Milestone: Priority: low
Severity: trivial Version: 2.7
Component: Optimization Keywords:
Focuses: Cc:

Description

I prepare script which replace four Spaces with Tab. I use this script in many cases.
Now I let him to do his best in "wp-includes" folder. About 2000+ spaces was replaced. It means that files has now 1500 charters less.

Attachments (1)

replace.patch (167.8 KB) - added by Simek 7 years ago.

Download all attachments as: .zip

Change History (6)

@Simek7 years ago

comment:1 @jacobsantos7 years ago

  • Milestone 2.7 deleted

So you reduced the total file size of WordPress by 1.5kB. And this helps how? Regardless, you should be sending the patch upstream to the external library repos.

As soon as the external library are updated, you are going to have to do the same thing again. Actually, you know should probably send inline documentation upstream as well.

Should be marked as invalid, but I'm not going to do it.

comment:2 @jacobsantos7 years ago

  • Milestone set to 2.8

comment:3 @westi7 years ago

  • Milestone 2.8 deleted
  • Resolution set to invalid
  • Status changed from new to closed

This is pointless.

As jacob points out most if not all of the files you are changing have upstreams and the changes will just revert with the next version.

comment:4 @jacobsantos7 years ago

  • Keywords has-patch removed

comment:5 @jacobsantos7 years ago

The problem also is that PEAR coding standards are to use 4 spaces instead of tabs. You are not going to be able to change that, so even if you send the patch up the PEAR repository, they aren't going to commit it because it would violate their coding standard. The other ones are on sourceforge, so I doubt you are going to change the developers minds on the spaces vs tabs debate. It is a preference thing.

Note: See TracTickets for help on using tickets.