get_post() assign by reference fails; should copy instead

[Sam_a]

get_post() tries to assign results of the $wpdb post query by reference (​wp-includes/post.php#L218) —

$_post = & $wpdb->get_row( […]

— but this fails (with notice "Only variables should be assigned by reference") because $wpdb->get_row() doesn't return a reference.

I think this must be a mistake, because normal assignment would work just as well and doesn't raise an error:

$_post = $wpdb->get_row( […]

[Sam_a]

get_post() assigns $wpdb row by value, not by reference. Stops E_NOTICEs in 2.6.2 and trunk

[ryan]

(In [8966]) Don't try to assign non-ref return value by ref. Props Sam_a. fixes #7783