WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#7807 closed defect (bug) (fixed)

String need plural form

Reported by: xibe Owned by:
Milestone: 2.7 Priority: normal
Severity: trivial Version: 2.7
Component: I18N Keywords: has-patch commit
Focuses: Cc:

Description

Strings from the plugin installer (wp-admin/includes/plugin-install.php) need ability to pluzalize:

Attachments (2)

7807.diff (1.4 KB) - added by DD32 7 years ago.
num-ratings-plural.diff (2.3 KB) - added by nbachiyski 7 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 @xibe7 years ago

And by "pluzalize", I mean "pluralize", which in the end is rather a way of saying it needs to handle single-rating note gracefully :)

comment:2 @DD327 years ago

  • Keywords needs-patch added
  • Owner changed from anonymous to DD32
  • Status changed from new to assigned
  • Version set to 2.7

Just taking owner of the ticket so i remember about it when time comes to submit the next plugin-install related patch

@DD327 years ago

comment:3 @DD327 years ago

  • Keywords has-patch commit added; needs-patch removed

comment:4 @DD327 years ago

(Can someone check i did that right? :))

comment:5 @ryan7 years ago

You don't need __() inside of ngettext. Also, the number substituted into the strings should be run through i18n_number_format() and subbed with %s.

comment:6 @DD327 years ago

  • Owner changed from DD32 to anonymous
  • Status changed from assigned to new

comment:7 @DD327 years ago

nbachiyski: Theres also one on line ~335 which it appears i missed in the patch i added.

comment:8 @ryan7 years ago

(In [9222]) i18n fixes for plugin intaller from DD32 and nbachiyski. see #7807

comment:9 @nbachiyski7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

I got it in the second patch.

Note: See TracTickets for help on using tickets.