Automatic links in comments should not bypass "Hold a comment in the queue if it contains x or more links"

[lloydbudd]

Automatic links in comments should not bypass "Hold a comment in the queue if it contains x or more links"

ENV: WP trunk r9039 (2.7-hemorrhage)

WordPress will automatically link domains like 'www.example.com' in comments. Currently, those automatically link domains are not counted towards "Hold a comment in the queue if it contains x or more links", and so a comment with only automatically linked domains will not end up in moderation.

This seems to be ripe for abuse by spammers, if they are not already taking advantage of it.

[tott]

patch wp-includes/comment.php against rev:9196

[westi]

I can't see that this patch achieves anything worthwhile.

The make_clickable function which makes those unlinked urls into links in run on display not save of the comment.

I understand that the current link counter will not count links which have no http on the front so we need a fix for that issue.

[lloydbudd]

Replying to westi:

I can't see that this patch achieves anything worthwhile.

The make_clickable function which makes those unlinked urls into links in run on display not save of the comment.

The scenario is whether or not the comments go into moderation, not whether the links are clickable. I just tested latest trunk (r9266) without and then with the patch, and with the patch the comments with unlinked domains are correctly are put in moderation.

[markjaquith]

(In [9782]) Count links in comments after performing automatic linking. props tott. fixes #7821

[mtdewvirus]

Causes problems with emoticons. #8627

[thee17]

Create new patch for 2.8 if need be but since this was fixxed in 2.7 it should remain closed

[tott]

revised patch against current trunk rev 10383

[tott]

double checked attachment:ticket:7821:patch_comment_moderation_link_count.2.diff​ against current trunk. neither the problems mentioned in #8627 nor the effect mentioned in #7268 appear.

please reconsider applying this revised version of the original patch.

[DD32]

[Aa][^>]*[Hh][Rr][Ee][Ff]

Err... Wouldnt just setting the i flag be much cleaner.... (i = PCRE case insensitive)

[tott]

Replying to DD32:

[Aa][^>]*[Hh][Rr][Ee][Ff]

Err... Wouldnt just setting the i flag be much cleaner.... (i = PCRE case insensitive)

indeed... that's right. /i should do the job, too

[ryan]

(In [10453]) Don't count emoticons toward link total. Props tott. fixes #8627 #7821 for trunk

[ryan]

(In [10454]) Don't count emoticons toward link total. Props tott. fixes #8627 #7821 for 2.7

[miqrogroove]

This was reopened and therefore not fixed in 2.7. Can the milestone be updated so that we know which version is working?