Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#7823 closed enhancement (duplicate)

Convert comment-reply.js to jQuery

Reported by: Viper007Bond Owned by: Viper007Bond
Milestone: Priority: lowest
Severity: minor Version: 2.7
Component: Template Keywords: needs-patch
Focuses: Cc:


Now that comment-reply.js has a jQuery dependency, the whole script can be cleaned up to use jQuery.

Ticket is a reminder to myself, but others are more than welcome to write the patch if they want to.

Change History (4)

#1 @Viper007Bond
7 years ago

  • Milestone changed from 2.8 to 2.7

#2 @DD32
7 years ago

I have to ask: Is the jQuery dependancy really required? it means themes which want to use the threading have to include an extra 40K library.. *shrug* what am i saying? the jQ Library is miniscule.. and it'll encourage theme authors to utilise it for JS in their themes, seems like the benefits outweigh the downsides to me.

#3 @Viper007Bond
7 years ago

  • Milestone 2.7 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Actually, we should probably use #7635 for this.

jQuery dependency was added for [9037]. I had written a patch before that one that managed to do it without jQuery, but it required an inline <script> to trigger the showing of the links (onload is horrible).

Note: See TracTickets for help on using tickets.