WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 15 months ago

#7835 closed defect (bug) (duplicate)

Change text in discussion settings for email notifications

Reported by: simonwheatley Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.0
Component: Text Changes Keywords: has-patch ux-feedback
Focuses: Cc:

Description

Currently there's two settings in Settings > Discussion, which are titled

Email me whenever:

  • Anyone posts a comment
  • A comment is held for moderation

This leads the user to believe that they are setting an option on their user account, when in fact they are setting a global option for the blog as a whole. Further, this option triggers notification of only one administrator (whichever is in the admin_email option, which I believe is set on installation).

Preferred Behaviour

  • Remove these options
  • Add user options to allow subscribing to these notifications on the profile page for users with permission to moderate comments
  • On installation, default the initial admin user to being subscribed to these notifications
  • On migration/upgrade, default the current admin_email user to being subscribed to these notifications

Quick Fix

Relabel the option so it reads: "Email [insert admin_email value] whenever:"

(This would require translation work.)

Attachments (1)

clarify label.diff (1.3 KB) - added by simonwheatley 3 years ago.
Fix the label wording to reflect the system actions

Download all attachments as: .zip

Change History (20)

comment:1 SimonK5 years ago

Actually, this setting is already used for e-mails to individual users, so the quick fix wouldn't solve this problem.

The admin doesn't gets mailed any longer with every comment, this setting affects the e-mails the post author gets, which means it should be a per user setting. Here's the code, found in wp-includes/comment.php in line 738.

		if ( get_option('comments_notify') && $commentdata['comment_approved'] && $post->post_author != $commentdata['user_ID'] )
			wp_notify_postauthor($comment_ID, $commentdata['comment_type']);
	}

Notice how it gets a global option, but triggers the wp_notify_postauthor function. This is really confusing, hope it can be fixed. This setting should either be used for comment notifications to the admin, or the setting should be moved to the user profile, so that each user can decide whether or not to receive e-mails of new comments. In this case a plugin can take over e-mailing the blog admin of each comment.

comment:2 ryan5 years ago

  • Milestone changed from 2.8 to Future Release

comment:3 Denis-de-Bernardy5 years ago

  • Component changed from General to Comments
  • Owner anonymous deleted

comment:4 Denis-de-Bernardy5 years ago

  • Keywords needs-testing 2nd-opinion added
  • Milestone changed from Future Release to 2.8.1

I believe this has been fixed in 2.8

comment:5 Denis-de-Bernardy5 years ago

  • Keywords reporter-feedback added; needs-testing 2nd-opinion removed

comment:6 janeforshort5 years ago

  • Summary changed from Admin comment notification setting is misleading, and behaviour is undesirable to Change text in discussion settings for email notifications
  • Type changed from defect (bug) to enhancement

These email settings (and the wording) are still there in 2.8. Planning to look at settings in-depth for 2.9/3.0 including personal options vs blog options, so changing this ticket to make simple text change in 2.8.1, and we will address the bigger problem in 2.9.

Change "Email me" to "Email blog admin" if that is still the functionality that is triggered.

comment:7 Denis-de-Bernardy5 years ago

  • Keywords reporter-feedback removed
  • Milestone changed from 2.8.1 to 2.9

comment:8 ryan4 years ago

  • Milestone changed from 2.9 to Future Release

comment:9 simonwheatley4 years ago

  • Type changed from enhancement to defect (bug)
  • Version changed from 2.6.1 to 3.0

This could be clarified with a simple wording change... like the attached diff, which changes the label to "E-mail the post author whenever [checkbox] anyone posts a comment" (rather than "Email me whenever...". How about it?

(Changing back to a defect, as the language is *wrong* and changing it is a correction not an enhancement. Hope that's OK.)

comment:10 hakre3 years ago

  • Keywords has-patch added

I did not check the patch if it needs refresh as this ticket is on future release.

simonwheatley3 years ago

Fix the label wording to reflect the system actions

comment:11 simonwheatley3 years ago

Amended wording in the patch to take into account that the post author is emailed when comments are published on their posts, and the admin email address is emailed when comments are available for moderation.

The wording could be better, any suggestions?

  • Settings group heading & legend (screen reader text): "E-mail me whenever" => "E-mail notifications"
  • "Anyone posts a comment" => "Email the post author when one of their posts is commented upon"
  • "A comment is held for moderation" => "Email the admin email address when a comment is held for moderation"

comment:12 hakre3 years ago

I like the clarification. That's makes it far more useable. The information who is mailed for what is currently missing and it's worth to know. This will help to run a Blog/Site.

comment:13 nacin3 years ago

  • Keywords ux-feedback added

comment:15 chexee3 years ago

@johnbillion Yes, so there's several a few patches for this problem. I like the language simonwheatley proposed, but change "upon" to "on".

comment:16 tfnab3 years ago

  • Cc martinhh@… added

comment:18 ocean9015 months ago

  • Keywords close added

comment:19 SergeyBiryukov15 months ago

  • Component changed from Comments to Text Changes
  • Keywords close removed
  • Milestone Future Release deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Closing in favor of #6286, which recently got some traction.

Note: See TracTickets for help on using tickets.